Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Separate Constants For VPN, TOR and MAIN_APP #240
Took Orbot constants and broke it apart based upon module usage. This will help with encapsulation and provided some additional cohesion for the VPN and the Tor Service modules.
Specifically, I introduced VpnConstants and VpnPrefs to contain Vpn specific information. The app also has a MainConstants, containing constants it needs.
I moved some methods from TorServiceUtils to VpnUtils to help with layering. The sharedPrefs method is duplicated but this assists with the separation for now.
The other thing to note is that the dnsPort is now set as a pref, rather than directly as a field on TorService. This removes a direct dependency.
Note this merge also includes #237 (Unfortunately I need this to build in my environment)