Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONE] Added a notification when infection is done #326

Merged
merged 6 commits into from Jun 12, 2019

Conversation

@ShayNehmad
Copy link
Contributor

ShayNehmad commented May 26, 2019

Feature / Fixes

Changes/Fixes the following feature

Fixes #325

  • Have you added an explanation of what your changes do and why you'd like to include them?

  • Have you successfully tested your changes locally?

  • Example screenshot/log transcript of the feature working
    image

Changes

  • Added notification to Monkey Island UI when infection is done.
  • Added npm run dev option
ShayNehmad added 2 commits May 26, 2019
… to only when changed.

also added dev mode to package.json - this helps with debugging JS errors live in chrome. use with 'npm run dev'
@danielguardicore danielguardicore changed the title [WIP] Added a notification when infection is done. [WIP] Added a notification when infection is done May 28, 2019
@ShayNehmad ShayNehmad changed the title [WIP] Added a notification when infection is done [CR] Added a notification when infection is done Jun 5, 2019
@ShayNehmad ShayNehmad requested a review from itaymmguardicore Jun 5, 2019
@ShayNehmad ShayNehmad self-assigned this Jun 5, 2019
@ShayNehmad ShayNehmad merged commit c320111 into develop Jun 12, 2019
@ShayNehmad ShayNehmad deleted the feature/325-notification-when-done branch Jun 12, 2019
@ShayNehmad ShayNehmad changed the title [CR] Added a notification when infection is done [DONE] Added a notification when infection is done Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.