Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONE] Use tempfile to create monkey directory #349

Merged
merged 1 commit into from Jun 12, 2019

Conversation

@ShayNehmad
Copy link
Contributor

ShayNehmad commented Jun 12, 2019

Instead of predetermined tmp paths.

Feature / Fixes

Fixes #348 .

  • Have you added an explanation of what your changes do and why you'd like to include them?

  • Have you successfully tested your changes locally?

  • Example screenshot/log transcript of the feature working
    After running the monkey locally...

C:\users\shay~1.neh\appdata\local\temp>dir | findstr monkey_dir
12/06/2019  17:51    <DIR>          monkey_dir

Changes

  • Now using tempfile to create monkey directory
Instead of predetermined tmp paths.
@ShayNehmad ShayNehmad changed the title Use tempfile to create monkey directory [WIP] Use tempfile to create monkey directory Jun 12, 2019
@ShayNehmad ShayNehmad changed the title [WIP] Use tempfile to create monkey directory [CR] Use tempfile to create monkey directory Jun 12, 2019
@ShayNehmad ShayNehmad self-assigned this Jun 12, 2019
@ShayNehmad ShayNehmad requested a review from danielguardicore Jun 12, 2019
@danielguardicore danielguardicore merged commit 302d4af into develop Jun 12, 2019
@danielguardicore danielguardicore deleted the bugfix/348-monkey-dir branch Jun 12, 2019
@ShayNehmad ShayNehmad changed the title [CR] Use tempfile to create monkey directory [DONE] Use tempfile to create monkey directory Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.