Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

determine if new report needs to be generated pending on latest updat… #358

Merged
merged 4 commits into from Jul 7, 2019

Conversation

@itaymmguardicore
Copy link
Contributor

itaymmguardicore commented Jun 18, 2019

Feature / Fixes

Determine whether to generate new attack report based on latest monkey modifytime

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Have you successfully tested your changes locally?
@itaymmguardicore itaymmguardicore requested a review from VakarisZ Jun 18, 2019
@itaymmguardicore itaymmguardicore self-assigned this Jun 18, 2019
@danielguardicore

This comment has been minimized.

Copy link
Contributor

danielguardicore commented Jun 19, 2019

Can we do this over the new DAL?

report =\
{
'techniques': {},
'meta': {'latest_monkey_modifytime': NodeService.get_latest_modified_monkey()[0]['modifytime']},

This comment has been minimized.

Copy link
@ShayNehmad

ShayNehmad Jun 20, 2019

Contributor

Code duplication between here and line 53. Perhaps it's a good opportunity to move this function + a wrapper for getting just the time to the models module and implement using mongoengine instead? :)

@danielguardicore

This comment has been minimized.

Copy link
Contributor

danielguardicore commented Jun 25, 2019

Looks good to me, lets solve the conflict and merge.

@ShayNehmad

This comment has been minimized.

Copy link
Contributor

ShayNehmad commented Jul 2, 2019

❤ for using the Monkey data model

@itaymmguardicore itaymmguardicore merged commit 79c4444 into develop Jul 7, 2019
@itaymmguardicore itaymmguardicore deleted the bugfix/fix-update-attack-report branch Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.