Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashing passwords to make sure we don't log passwords plaintext #438

merged 3 commits into from Sep 19, 2019


Copy link

ShayNehmad commented Sep 18, 2019

Feature / Fixes

Fixes #434.

@ShayNehmad ShayNehmad added the Bug label Sep 18, 2019
@ShayNehmad ShayNehmad requested a review from VakarisZ Sep 18, 2019
@ShayNehmad ShayNehmad self-assigned this Sep 18, 2019

This comment has been minimized.

Copy link

danielguardicore commented Sep 18, 2019

Please also hash hashes

Copy link

VakarisZ left a comment

As Daniel pointed out hashing hashes would also make sense. Create an issue for that probably.

@danielguardicore danielguardicore merged commit 8c69cc0 into develop Sep 19, 2019
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Travis CI - Pull Request Build Passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.