From 29b72c06f76e1063865d733a27aecf1117f550c6 Mon Sep 17 00:00:00 2001 From: thebigbone Date: Sat, 23 Mar 2024 12:39:02 +0530 Subject: [PATCH 1/2] use HTTPStatus.OK instead of literal status code 200 --- guardrails/validators/endpoint_is_reachable.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/guardrails/validators/endpoint_is_reachable.py b/guardrails/validators/endpoint_is_reachable.py index c5fd33895..209ca3f59 100644 --- a/guardrails/validators/endpoint_is_reachable.py +++ b/guardrails/validators/endpoint_is_reachable.py @@ -1,4 +1,5 @@ from typing import Any, Dict +from http import HTTPStatus from guardrails.logger import logger from guardrails.validator_base import ( @@ -31,7 +32,7 @@ def validate(self, value: Any, metadata: Dict) -> ValidationResult: # Check that the URL exists and can be reached try: response = requests.get(value) - if response.status_code != 200: + if response.status_code != HTTPStatus.OK: return FailResult( error_message=f"URL {value} returned " f"status code {response.status_code}", From 89b9fb43306cc5cd065408896bed7bde5d5c7996 Mon Sep 17 00:00:00 2001 From: thebigbone Date: Wed, 27 Mar 2024 19:04:08 +0530 Subject: [PATCH 2/2] ran autoformat for fixing linting errors --- guardrails/validators/endpoint_is_reachable.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guardrails/validators/endpoint_is_reachable.py b/guardrails/validators/endpoint_is_reachable.py index 209ca3f59..27853c990 100644 --- a/guardrails/validators/endpoint_is_reachable.py +++ b/guardrails/validators/endpoint_is_reachable.py @@ -1,5 +1,5 @@ -from typing import Any, Dict from http import HTTPStatus +from typing import Any, Dict from guardrails.logger import logger from guardrails.validator_base import (