New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API and test improvements #58

merged 11 commits into from Jun 16, 2018


None yet
4 participants

mgechev commented Jun 7, 2018

Most of the changes are related to refactoring and the introduced e2e tests.

This PR introduces the following changes:

  • API improvements as discussed in #42
  • Externalizes the guess method for predictions so we can later publish it as a separate package and reuse it across packages
  • Introduces infrastructure for e2e testing with puppeteer
  • Makes the payload smaller for apps which are going to be consumers of guess only (i.e., won't need prefetching functionality on route change, such as Gatsby)
  • Makes the route extraction API asynchronous

@KyleAMathews @khempenius would you share your opinion about the current API? How convenient it's going to be for Gatsby and would we be able to reuse it in the static page solution (look at packages/webpack/src/runtime/guess.ts)?

Fix #42.

mgechev added some commits Jun 6, 2018

Merge branch 'minko/external-provider' into minko/api
* minko/external-provider:
  Update reportProvider format
  Allow custom report provider

mgechev added some commits Jun 7, 2018

@mgechev mgechev changed the title from [WIP] API and test improvements to API and test improvements Jun 9, 2018


After reading through the commits, I think on the whole the API changes here are reasonable. I didn't have any further concrete feedback to share.

@mgechev mgechev merged commit 51258ad into master Jun 16, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@mgechev mgechev deleted the minko/api branch Jun 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment