New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API and test improvements #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* minko/external-provider: Update reportProvider format Allow custom report provider
* master:
mgechev
force-pushed
the
minko/api
branch
4 times, most recently
from
June 8, 2018 20:24
f2c7d7b
to
2e1b0a1
Compare
addyosmani
approved these changes
Jun 16, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reading through the commits, I think on the whole the API changes here are reasonable. I didn't have any further concrete feedback to share.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes are related to refactoring and the introduced e2e tests.
This PR introduces the following changes:
guess
method for predictions so we can later publish it as a separate package and reuse it across packagesguess
only (i.e., won't need prefetching functionality on route change, such as Gatsby)@KyleAMathews @khempenius would you share your opinion about the current API? How convenient it's going to be for Gatsby and would we be able to reuse it in the static page solution (look at
packages/webpack/src/runtime/guess.ts
)?Fix #42.