Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API and test improvements #58

Merged
merged 11 commits into from Jun 16, 2018
Merged

API and test improvements #58

merged 11 commits into from Jun 16, 2018

Conversation

@mgechev
Copy link
Member

@mgechev mgechev commented Jun 7, 2018

Most of the changes are related to refactoring and the introduced e2e tests.

This PR introduces the following changes:

  • API improvements as discussed in #42
  • Externalizes the guess method for predictions so we can later publish it as a separate package and reuse it across packages
  • Introduces infrastructure for e2e testing with puppeteer
  • Makes the payload smaller for apps which are going to be consumers of guess only (i.e., won't need prefetching functionality on route change, such as Gatsby)
  • Makes the route extraction API asynchronous

@KyleAMathews @khempenius would you share your opinion about the current API? How convenient it's going to be for Gatsby and would we be able to reuse it in the static page solution (look at packages/webpack/src/runtime/guess.ts)?

Fix #42.

mgechev added 8 commits Jun 6, 2018
wip
* minko/external-provider:
  Update reportProvider format
  Allow custom report provider
wip
* master:
@mgechev mgechev force-pushed the minko/api branch 4 times, most recently from f2c7d7b to 2e1b0a1 Jun 7, 2018
@mgechev mgechev force-pushed the minko/api branch from f6eb3d1 to ba85bd6 Jun 8, 2018
@mgechev mgechev force-pushed the minko/api branch from e5cd9bd to 0aa902d Jun 9, 2018
@mgechev mgechev changed the title [WIP] API and test improvements API and test improvements Jun 9, 2018
Copy link
Contributor

@addyosmani addyosmani left a comment

After reading through the commits, I think on the whole the API changes here are reasonable. I didn't have any further concrete feedback to share.

@mgechev mgechev merged commit 51258ad into master Jun 16, 2018
4 checks passed
4 checks passed
@travis-ci
Travis CI - Branch Build Passed
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mgechev mgechev deleted the minko/api branch Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants