Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Angular parser to support dynamic imports #93

Merged
merged 15 commits into from May 14, 2019

Conversation

Projects
None yet
1 participant
@mgechev
Copy link
Member

commented May 13, 2019

The primary purpose of this PR is to update the Angular parser implementation to include support for dynamic imports that we introduced as part of version 8.0.0.

Version 8 required the manual implementation of the complete functionality. A side implication is that we no longer depend on @angular/core, @angular/compiler, and ngast.

Additionally, the PR introduces partial evaluation of expressions. This means that:

const path = 'foo',
const foo = 'foo';
const bar = 'foo.module#FooModule';
const routes: Routes = [{
  path: path,
  loadChildren: foo + '/' + bar
}];

Will work! There's still a bit more work to ensure that the enhanced object literal syntax functions correctly.

mgechev added some commits May 12, 2019

@mgechev mgechev merged commit 5402389 into master May 14, 2019

2 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details

@mgechev mgechev deleted the minko/ng-parser branch May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.