From 87cefa228962c19afcc5c9f331c25dd77e5bf4c1 Mon Sep 17 00:00:00 2001 From: Kang-min Liu Date: Sat, 3 Jun 2023 12:54:18 +0900 Subject: [PATCH 1/6] [CI] For perl 5.8.9, pin the versions of certain toolchain modules. --- .github/workflows/ci.yml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c2573271..6df916b5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -40,7 +40,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - perl: [ '5.8', '5.10' ] + perl: [ '5.10', '5.12' ] container: image: perl:${{ matrix.perl }} name: Perl ${{ matrix.perl }} @@ -50,3 +50,15 @@ jobs: - run: cpanm --quite --notest --installdeps . - run: cpanm --quite --notest App::Prove - run: prove -lrv t + + prove5.8.9: + runs-on: ubuntu-latest + container: + image: perl:5.8.9 + name: Perl 5.8.9 + steps: + - uses: actions/checkout@v2 + - run: perl -V + - run: cpanm --quite --notest Pod::Man@4.10 Test::Deep@1.130 App::Prove + - run: cpanm --quite --notest --installdeps . + - run: prove -lrv t From d3c2a5d4f361a464a70135567d0e6c008cc530ff Mon Sep 17 00:00:00 2001 From: Kang-min Liu Date: Sat, 3 Jun 2023 13:06:38 +0900 Subject: [PATCH 2/6] fix: id of workflows The workflow is not valid. .github/workflows/ci.yml (Line: 54, Col: 3): The identifier 'prove5.8.9' is invalid. IDs may only contain alphanumeric characters, '_', and '-'. IDs must start with a letter or '_' and and must be less than 100 characters. --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6df916b5..71049a14 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -51,7 +51,7 @@ jobs: - run: cpanm --quite --notest App::Prove - run: prove -lrv t - prove5.8.9: + prove5_8_9: runs-on: ubuntu-latest container: image: perl:5.8.9 From 072eaa62c6a50ee2c24e3c790cb7a577072e82c9 Mon Sep 17 00:00:00 2001 From: Kang-min Liu Date: Sat, 3 Jun 2023 13:27:04 +0900 Subject: [PATCH 3/6] recent Test::Deep requires perl 5.12. This means perl 5.10 is also considered as a legacy. --- .github/workflows/ci.yml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 71049a14..c995b5f9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -40,7 +40,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - perl: [ '5.10', '5.12' ] + perl: ['5.12', '5.14'] container: image: perl:${{ matrix.perl }} name: Perl ${{ matrix.perl }} @@ -51,11 +51,14 @@ jobs: - run: cpanm --quite --notest App::Prove - run: prove -lrv t - prove5_8_9: + prove_legacy: runs-on: ubuntu-latest + strategy: + matrix: + perl: ['5.8', '5.10'] container: - image: perl:5.8.9 - name: Perl 5.8.9 + image: perl:${{ matrix.perl }} + name: Perl ${{ matrix.perl }} steps: - uses: actions/checkout@v2 - run: perl -V From 85d39ee810feac5576adbd9b2e52ecace7209283 Mon Sep 17 00:00:00 2001 From: Kang-min Liu Date: Sat, 3 Jun 2023 17:22:12 +0900 Subject: [PATCH 4/6] [CI] it looks like git has to be inside container ... so that action/checkout@v2 could do a `git clone` instead of downloading the repo archive. ref: https://github.com/actions/checkout/issues/175#issuecomment-595357510 --- .github/workflows/ci.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c995b5f9..52c2788c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -8,12 +8,14 @@ jobs: container: image: perl:5.32 steps: + - name: install dependencies + run: | + apt install -y git + cpanm --notest --quiet App::PerlNitpick - uses: actions/checkout@v2 - uses: gugod/action-perlcritic@fun with: directory: "lib script t dev-bin" - - name: install perlnitpick - run: cpanm --notest --quiet App::PerlNitpick - name: run perlnitpick run: perlnitpick --inplace --rules=RemoveTrailingWhitespace,RemoveUnusedVariables,RemoveUnusedInclude,RemoveUnusedImport . - name: suggester From afe4a3c1b6dbff1ee700c25238f11e2b9b431afb Mon Sep 17 00:00:00 2001 From: Kang-min Liu Date: Sat, 3 Jun 2023 17:28:30 +0900 Subject: [PATCH 5/6] no need to run perlcritic here. --- .github/workflows/ci.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 52c2788c..7bf96884 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,9 +13,6 @@ jobs: apt install -y git cpanm --notest --quiet App::PerlNitpick - uses: actions/checkout@v2 - - uses: gugod/action-perlcritic@fun - with: - directory: "lib script t dev-bin" - name: run perlnitpick run: perlnitpick --inplace --rules=RemoveTrailingWhitespace,RemoveUnusedVariables,RemoveUnusedInclude,RemoveUnusedImport . - name: suggester From c92ccdafbe870f0d25af7a387eb4456861841a8c Mon Sep 17 00:00:00 2001 From: Kang-min Liu Date: Sat, 3 Jun 2023 17:36:37 +0900 Subject: [PATCH 6/6] [CI] give up on this approach. --- .github/workflows/ci.yml | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7bf96884..e1d3fbd9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -3,23 +3,6 @@ name: CI on: pull_request jobs: - lint: - runs-on: ubuntu-latest - container: - image: perl:5.32 - steps: - - name: install dependencies - run: | - apt install -y git - cpanm --notest --quiet App::PerlNitpick - - uses: actions/checkout@v2 - - name: run perlnitpick - run: perlnitpick --inplace --rules=RemoveTrailingWhitespace,RemoveUnusedVariables,RemoveUnusedInclude,RemoveUnusedImport . - - name: suggester - uses: reviewdog/action-suggester@v1 - with: - tool_name: perlnitpick - yath: runs-on: ubuntu-latest strategy: