Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better quoting in csh_wrapper and cshrc #662

Merged
merged 1 commit into from Mar 25, 2019
Merged

better quoting in csh_wrapper and cshrc #662

merged 1 commit into from Mar 25, 2019

Conversation

@xenu
Copy link
Contributor

xenu commented Feb 24, 2019

In some cases it might not be needed but with csh (and shells in
general) it's better to be safe than sorry.

For example, it makes the following work (note the space in the
-A argument):

perlbrew install perl-5.28.1 -A define:optimize='-O0 -ggdb3'

In some cases it might not be needed but with csh (and shells in
general) it's better to be safe than sorry.

For example, it makes the following work (note the space in the
-A argument):

perlbrew install perl-5.28.1 -A define:optimize='-O0 -ggdb3'
@xenu xenu force-pushed the xenu:develop branch from 458f8e0 to 720f662 Feb 24, 2019
@xenu xenu changed the title better quoting in csh_wrapper and chsrc better quoting in csh_wrapper and cshrc Feb 24, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 24, 2019

Coverage Status

Coverage remained the same at 84.702% when pulling 720f662 on xenu:develop into ce03925 on gugod:develop.

@gugod
gugod approved these changes Mar 25, 2019
Copy link
Owner

gugod left a comment

I only eye-balled this but it looks OK to me.

Thank you @xenu, for spending times on this project.

@gugod gugod merged commit e211ae5 into gugod:develop Mar 25, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 84.702%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.