New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow temp directory created in test to be able to be cleaned up. #10

Merged
merged 1 commit into from Aug 2, 2015

Conversation

Projects
None yet
2 participants
@jmaslak
Contributor

jmaslak commented Aug 1, 2015

This is a very trivial change - I suspect you meant to do this, since you saved the starting location before the chdir (into $home). The temp directory couldn't be removed because the test chdir()-ed into the temp directory.

It avoids this warning message during make test:
t/01.exclude-list.t ......................... 1/3 cannot remove path when cwd is /tmp/vUtktuDjJl/ignorewfiles for /tmp/vUtktuDjJl: at /usr/share/perl/5.20/File/Temp.pm line 778.

That message didn't impact whether or not tests passed, but it still is good to clean up that directory.

FYI - I got your module in the CPAN Pull Request Challenge, and will likely be doing some more pull requests, but I thought it probably best to separate the changes in case you like some but not others, hence this extremely trivial pull request. I'm focusing primarily on test failures seen by cpantesters.

Allow temp directory created in test to be able to be cleaned up.
Previously, this couldn't happen because the test chdir-ed to the temp
directory.

gugod added a commit that referenced this pull request Aug 2, 2015

Merge pull request #10 from jmaslak/master
Allow temp directory created in test to be able to be cleaned up.

@gugod gugod merged commit 284691e into gugod:master Aug 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gugod

This comment has been minimized.

Show comment
Hide comment
@gugod

gugod Aug 2, 2015

Owner

@jmaslak appreciated for all the PRs and improvements!

Owner

gugod commented Aug 2, 2015

@jmaslak appreciated for all the PRs and improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment