New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use perl that Test::Continuous uses to run prove, even if not in path #11

Merged
merged 1 commit into from Aug 2, 2015

Conversation

Projects
None yet
2 participants
@jmaslak
Contributor

jmaslak commented Aug 2, 2015

Instead of relying on the path to find 'prove', this uses $^X. This is more compatible with multiple installations of Perl, as it will assume that you want to test the application under whatever version of
Perl is running Test::Continuous, rather than what is in the system path. As a nice side-effect of this, cpantesters that have multiple perl versions installed will not report test failures for this reason (that is the reason for the vast majority of test failures being reported right now). I validated this passes tests on Solaris, Windows (for versions of Cygwin that allow pre-requisite modules to install), and Linux x64 and ARMv7.

The use of $^X and building a script that does what prove does (call App::Prove with the appropriate arguments) rather than to try to find prove in the path is to try to allow this to work on systems that don't necessarily have Unix-like paths, or where prove is installed in a different location than Perl.

gugod added a commit that referenced this pull request Aug 2, 2015

Merge pull request #11 from jmaslak/pass_tests_multi_perl_install
Use perl that Test::Continuous uses to run prove, even if not in path

@gugod gugod merged commit 1b30e55 into gugod:master Aug 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment