Fixes Multi-caret selection not working right#121
Merged
Merged
Conversation
Move multi-caret.md from examples/ted/docs/ to Docs/Help/ and append multi-caret editing documentation to selection.md. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The drag handler (LeftButtonPressed | PositionReport) fired after every Ctrl+Click press and called ExtendCaretTo, which moved the primary caret to the click position and created an unwanted selection. This made it impossible to place additional carets above the primary, and caused both slashes of '//' to appear highlighted when clicking on a comment (the primary cursor ended up on one slash while the additional caret overlay painted the other). Fix: track _suppressDragUntilRelease — set on Ctrl+Click press, cleared on release — so the drag handler ignores PositionReport events that follow a multi-caret click. Also restore the normal attribute after MultiCaretRenderer.Draw to prevent any future attribute leak to adjacent cells. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The simple foreground/background invert was not visually distinct enough. Switch to Underline|Blink on the normal colors so secondary carets stand out clearly from both regular text and selection highlights. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…quences Add FAQ section to README documenting font ligature visual artifacts. Cell buffer and ANSI output are provably correct — the visual bleed users see with fonts like Cascadia Code or Fira Code is a terminal rendering issue, not an Editor bug. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
Ctrl+Click on a C# comment (//) makes both slashes show the multi-caret attribute — placing a caret on a //\ comment highlights both slash characters with the multi-caret inverted attribute instead of just the single character at the click position.
Cannot Ctrl+Click above the main caret — additional carets can only be placed below the primary caret position, not above it.
Changes so far