TrueColor is no longer working on WindowsDriver

[tig]

I probably broke this. Sigh.

[BDisp]

I already saw that. My workaround was this:

		_isWindowsTerminal = Environment.GetEnvironmentVariable ("WT_SESSION") != null ||
			Environment.GetEnvironmentVariable ("VSAPPIDNAME") != null;

[dodexahedron]

Can't just check OS platform instead?

OperatingSystem.IsWindows ( )

[tig]

Can't just check OS platform instead?

OperatingSystem.IsWindows ( )

Nope. Windows Terminal != conhost etc... We've spent a LOT of effort on this and still don't have it right (and the sands below us are moving)...

• Fixes #2961. v2 - WindowsDriver isn't render well on conhost terminal size. #2962
• In the v2 version, using Chinese will cause UI confusion. #2928

To name a few...

[tig]

Can't just check OS platform instead?

OperatingSystem.IsWindows ( )

Nope. Windows Terminal != conhost etc... We've spent a LOT of effort on this and still don't have it right (and the sands below us are moving)...

• Fixes #2961. v2 - WindowsDriver isn't render well on conhost terminal size. #2962
• In the v2 version, using Chinese will cause UI confusion. #2928

To name a few...

I have ideas of how to be far more graceful about this in

• Refactor ConsoleDrivers to support ANSI sequences natively (e.g. Virtual Terminal Sequences on Windows) #2610