feat: useless try-except

[ScDor]

closes: #58

1. I am not sure whether 3xx is the right code, wdyt?
2. Is an auto-fix relevant in this case?

[guilatrova]

That is a good idea.

Thanks for the suggestion and for following the commit guidelines.

I'll test it later this week/early next week and provide more feedback

[guilatrova]

I left some minor comments. Great work!

Getting to your questions:

I am not sure whether 3xx is the right code, wdyt?

Since it happens inside the except block where someone mistakenly adds a bare raise, and not inside the try block itself this new violation fits better in the 2xx group.

Is an auto-fix relevant in this case?

I don't think so, it's better to leave the developer to decide what he wanted. Maybe he should remove the try/except altogether e.g.

try: # Whole block is useless
   something()
except Exception:
   raise

Maybe he has a finally, so he would just delete the except block

try:
   something()
except Exception: # Only this block is useless
   raise
finally:
   do_something_else()

---

Feel free to fix these items by either:

• Using the refactor: prefix on commits; o
• Amending your commits to the first one

Whatever you decide is fine 👍

[guilatrova]

It was a pleasure 🤝