New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor schema/create-dimension! #7

Merged
merged 4 commits into from Nov 19, 2014

Conversation

Projects
None yet
2 participants
@nberger
Contributor

nberger commented Nov 18, 2014

Moves groups validation to api front
Requires group_only or grouped_by option to be passed

nberger added some commits Nov 18, 2014

Refactor schema/create-dimension!
Moves groups validation to api front
Requires group_only or grouped_by option to be passed
Remove :pre from add-dimension!
The default should be (when neither of both options were passed):

        `{:group_only false :grouped_by [[]]`

The precondition was preventing assuming that default

guilespi added a commit that referenced this pull request Nov 19, 2014

Merge pull request #7 from nberger/refactor-create-dimension
Refactor schema/create-dimension!

@guilespi guilespi merged commit c357010 into guilespi:master Nov 19, 2014

@nberger nberger deleted the nberger:refactor-create-dimension branch May 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment