New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment #43

Merged
merged 1 commit into from Feb 27, 2017

Conversation

Projects
None yet
3 participants
@choroba
Contributor

choroba commented Feb 27, 2017

The mentioned test was renamed and cloned.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 27, 2017

Coverage Status

Coverage remained the same at 89.987% when pulling 096232c on choroba:trivial-comment into f3b68b6 on guillaumeaubert:master.

coveralls commented Feb 27, 2017

Coverage Status

Coverage remained the same at 89.987% when pulling 096232c on choroba:trivial-comment into f3b68b6 on guillaumeaubert:master.

@guillaumeaubert

This comment has been minimized.

Show comment
Hide comment
@guillaumeaubert

guillaumeaubert Feb 27, 2017

Owner

Good catch! The documentation in t/22-run-die.t is actually a leftover of the cloning but does not match the purpose of the test (which is to make sure that die signals in plugins are correctly trapped by hooks). I must have forgotten to remove it before I committed the new test.

If you want to remove lines 3-23 in t/22-run-die.t (and perhaps replace them with the explanation above-mentioned), then you can amend lib/App/GitHooks/Hook/PostCheckout.pm to point to t/21-run-dash.t only.

Owner

guillaumeaubert commented Feb 27, 2017

Good catch! The documentation in t/22-run-die.t is actually a leftover of the cloning but does not match the purpose of the test (which is to make sure that die signals in plugins are correctly trapped by hooks). I must have forgotten to remove it before I committed the new test.

If you want to remove lines 3-23 in t/22-run-die.t (and perhaps replace them with the explanation above-mentioned), then you can amend lib/App/GitHooks/Hook/PostCheckout.pm to point to t/21-run-dash.t only.

@choroba

This comment has been minimized.

Show comment
Hide comment
@choroba

choroba Feb 27, 2017

Contributor

Updated.

Contributor

choroba commented Feb 27, 2017

Updated.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 27, 2017

Coverage Status

Coverage remained the same at 89.987% when pulling df9b959 on choroba:trivial-comment into f3b68b6 on guillaumeaubert:master.

coveralls commented Feb 27, 2017

Coverage Status

Coverage remained the same at 89.987% when pulling df9b959 on choroba:trivial-comment into f3b68b6 on guillaumeaubert:master.

@guillaumeaubert guillaumeaubert merged commit d94a7b8 into guillaumeaubert:master Feb 27, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 89.987%
Details
@guillaumeaubert

This comment has been minimized.

Show comment
Hide comment
@guillaumeaubert

guillaumeaubert Feb 27, 2017

Owner

Merged - thank you!

Owner

guillaumeaubert commented Feb 27, 2017

Merged - thank you!

@choroba choroba deleted the choroba:trivial-comment branch Feb 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment