Skip to content

Support deferred tasks in dev #39

Merged
merged 5 commits into from Feb 27, 2012

2 participants

@mrspandex

Deferred tasks previously got a 404 looking for a URL hosted by the AppEngine runtime.

@mrspandex mrspandex commented on the diff Feb 2, 2012
src/play/modules/gae/GAEPlugin.java
@@ -23,14 +21,6 @@
@Override
public void onLoad() {
// Remove Jobs from plugin list
- /*
@mrspandex
mrspandex added a note Feb 2, 2012

No need to keep around commented out code when we have version control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@mrspandex mrspandex commented on the diff Feb 2, 2012
src/play/modules/gae/PlayDevEnvironment.java
import play.Play;
import play.mvc.Http;
import play.mvc.Scope.Session;
import play.server.Server;
+import java.io.File;
+import java.util.HashMap;
+import java.util.Map;
+
public class PlayDevEnvironment implements Environment, LocalServerEnvironment {
public static PlayDevEnvironment create() {
PlayDevEnvironment instance = new PlayDevEnvironment();
ApiProxyLocalFactory factory = new ApiProxyLocalFactory();
ApiProxyLocal proxy = factory.create(instance);
@mrspandex
mrspandex added a note Feb 2, 2012

I used the test config for the datastore as well to be consistent

@mandubian
Collaborator
mandubian added a note Mar 12, 2012

Apparently this commit creates problems due to the use of test config.
Do you think we could remove that ?

Regards
Pascal

@mrspandex
mrspandex added a note Mar 12, 2012

Unfortunately, that is the meat of this commit. Behind the scenes, the test config works very similarly to what was being set before, but apparently something is being set that wasn't before. Is this referring to #44?

@mandubian
Collaborator
mandubian added a note Mar 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@mrspandex mrspandex commented on the diff Feb 2, 2012
src/play/modules/gae/PlayDevEnvironment.java
@@ -41,21 +52,25 @@ public String getVersionId() {
@Override
public String getEmail() {
@mrspandex
mrspandex added a note Feb 2, 2012

When copying this environment for the task queue, I was getting null pointers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@mandubian mandubian merged commit baa08c8 into guillaumebort:master Feb 27, 2012
@mandubian
Collaborator

Thanks for contribution!
Pascal

@mandubian mandubian pushed a commit that referenced this pull request Mar 12, 2012
Pascal Voitot temporarily commented code from Issue #39 1ba8e70
@mandubian mandubian pushed a commit that referenced this pull request Mar 12, 2012
Pascal Voitot temporarily commented code from Issue #39 3d9c9ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.