Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Implement { } ( ) motions. #152

Closed
thesamet opened this Issue · 14 comments

2 participants

@thesamet

That is, paragraph and sentence backward and forward.

@guillermooo guillermooo was assigned
@guillermooo
Owner

@thesamet How does Vim define a sentence?

@thesamet
@thesamet
@guillermooo
Owner

Is it too different from the one I've just pushed for Vintageous? I see Vintage uses the built-in move instead of a custom command.

@thesamet

Thanks for the quick turnaround time!

{ } Seem to work correctly with one minor issue is that if there are multiple blank lines it shouldn't stop on each one of them (it should just skip to the next set of blank lines)

( ) does not work at all like in vim. ) seems to go to the end of the current sentence instead of the beginning of the next one. Sentence boundaries do not seem to be detected correctly.

@thesamet

Also, currently those motions do not work in visual mode.

@guillermooo
Owner

Hm... they do here. Do you have a repro?

@thesamet

Were you referring to the comment about visual mode or the comment about the correctness of the motion?

@guillermooo
Owner

The correctness issue is clear, thanks. I was taking about the visual mode issue.

v} extends the sels for me.

@thesamet
@guillermooo
Owner

So many modes, so little time! :) Ok, that's not implemented yet.

@guillermooo
Owner

Improve (, ) before closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.