Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

memory leak in plugin_host #171

Closed
guillermooo opened this Issue Mar 27, 2013 · 7 comments

Comments

Projects
None yet
2 participants
Owner

guillermooo commented Mar 27, 2013

Every time a Vintageous command is executed, memory is leaked.

@guillermooo guillermooo was assigned Mar 27, 2013

Owner

guillermooo commented Apr 1, 2013

Right now this is the only blocking issue for a 1.0 release.

Side note: I might suggest that the following task is also 1.0 blocking: #167

Owner

guillermooo commented Apr 2, 2013

Confirmed as a bug in S3. I suspect intrinsic Vintageous issues might have exacerbated the problem, so let's check again with the next S3 build. I'm half-way through quite a large refactor to address this, but I will put in on hold until after 1.0 if the fix for S3 seals the leak.

Owner

guillermooo commented Apr 2, 2013

Also 1.0 blocking: #179

Owner

guillermooo commented Apr 4, 2013

Improved somewhat with the fix in 3023, but the leak persists. Vintage suffers from the same problem.

The low-hanging fruit here would be to optimize use of descriptors in Settings, Registers, etc. That won't seal the leak, but it should reduce it.

Greater redesigns can be pushed back until after 1.0.

Owner

guillermooo commented Apr 5, 2013

Detected another leak in plugin_host. When it gets fixed, this one will probably follow suit.

(The global state handling is still quite redundant and might leak memory too, but it shouldn't be as noticeable as it is now.)

Owner

guillermooo commented Apr 9, 2013

S3's memory leaks seem to be finally fixed in build 3025.

@guillermooo guillermooo closed this Apr 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment