New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar fixes, add info, remove useless stuff #54

Closed
wants to merge 6 commits into
base: sublime-text-3
from

Conversation

Projects
None yet
2 participants
@valrus

valrus commented Aug 8, 2014

My main reason for this pull request is to remove some condescending, patronizing or insulting turns of phrase and some text that serves no purpose. To help that go down easier, I've also fixed some grammatical problems—particularly missing antecedents, but some other stuff too—and added information in the regex section about how to actually turn them on.

valrus added some commits Aug 4, 2014

Remove pointless stuff
I agree with almost everything here: http://yfl.bahmanm.com/Members/ttmrichter/software-reviews/sublime-text-2-review#section-9 and so I'm removing the most obviously useless things from the docs. That means the insulting generalizations in the Vi section, the entire useless Emacs section, and the thoroughly extraneous "Be Sublime" section.
Fix missing antecedents and condescension
Some sentences had ambiguous antecedents. Fix those. Also, remove some pointlessly patronizing comments.
Remove pointless stuff, explain activating regexes
The reference to "nerds" is extraneous and unfunny, as is the "hurt people's feelings" comment.
Docs should explain how to turn on regexes.
Move Boost syntax link
Link to RE syntax after reference to learning the basics rather than tacking it on at the end of the section.
@valrus

This comment has been minimized.

Show comment
Hide comment
@valrus

valrus Aug 8, 2014

I removed the whole Emacs section, which said "If you are an Emacs user, you're probably not reading this," thereby negating its own purpose. But perhaps it could be useful if it linked to https://github.com/grundprinzip/sublemacspro instead. I'd be happy to make that change.

valrus commented Aug 8, 2014

I removed the whole Emacs section, which said "If you are an Emacs user, you're probably not reading this," thereby negating its own purpose. But perhaps it could be useful if it linked to https://github.com/grundprinzip/sublemacspro instead. I'd be happy to make that change.

@FichteFoll

This comment has been minimized.

Show comment
Hide comment
@FichteFoll

FichteFoll Dec 5, 2014

Collaborator

basic_concepts.rst has been revised as of #83 and #97, and search_and_replace_overview.rst will very likely also be in the near future (with the affected section to be reworded).

Thanks for your contribution however, much appreciated.

Collaborator

FichteFoll commented Dec 5, 2014

basic_concepts.rst has been revised as of #83 and #97, and search_and_replace_overview.rst will very likely also be in the near future (with the affected section to be reworded).

Thanks for your contribution however, much appreciated.

@FichteFoll FichteFoll closed this Dec 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment