Added notice for 4.0.0 vs 3.9.1 documentation #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Can you also update the website to point to docs at the correct tag? The repo is gulpjs.github.io |
|
Oh, I couldn't find the repo at first. Will do. |
|
@Lucretiel Thanks! This should reduce confusion. |
phated
reviewed
Feb 7, 2018
|
I was considering terminology like "stable" or "release, too.
…On Wed, Feb 7, 2018 at 11:20 AM, Blaine Bublitz ***@***.***> wrote:
***@***.**** commented on this pull request.
I think I'll change "standard" to "default" when I'm back at a computer.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2121 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABvSrdtqua7Nn1QqkQOa5daJWhSytuHUks5tSfdrgaJpZM4R9ITm>
.
|
|
Stable specifically means "not prerelease" and 4.0.0 has been released (it's just not default because the docs aren't complete) |
|
Yeah, that's why I settled on standard. I'm happy with whatever terminology
you think is best.
…On Wed, Feb 7, 2018, 12:26 PM Blaine Bublitz ***@***.***> wrote:
Stable specifically means "not prerelease" and 4.0.0 has been released
(it's just not default because the docs aren't complete)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2121 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABvSrQgWoflDeuvJgQM8LmnSDZlbjFf8ks5tSgbugaJpZM4R9ITm>
.
|
This comment has been minimized.
This comment has been minimized.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Because the master branch is the authoritative source of documentation, it can be confusing for developers who have used
npm install gulp(or joined a project using gulp 3) that the master branch is for a different major release. This PR adds a simple notification to the API docs, which are linked to from https://gulpjs.com/, that the standard version installed bynpm install gulp.It's worth noting that, while it might be obvious to people familiar with gulp's development, there's no indication that there's a mismatch between master and the current node release anywhere on
https://gulpjs.com/, nor onmaster:docs/API.md, nor in any of the top google search results for "gulpjs documentation".