adds contribute section #47

Merged
merged 4 commits into from Jan 10, 2017

Projects

None yet

3 participants

@bdougie
Contributor
bdougie commented Jan 9, 2017 edited

What is this?

I have completed #37 adding the contribute section.

See it live here

Feedback

This is an iteration and I am not a designer, but looking for initial feedback. My thought is that there is a lot of "gulp red" on the page, but that will change when #43 is completed and merged.

red

I tried using as much existing CSS, but feel free to provide feedback on anything that could be cleaned up. Reference the preview and let me know though 👉🏾 https://deploy-preview-1--pharmacist-lisa-21114.netlify.com/

copy

I went off the copy on the mock, but if there are any changes you want made, let me know.

screenshot 2017-01-09 10 58 50

@bdougie bdougie closed this Jan 9, 2017
@bdougie bdougie reopened this Jan 9, 2017
index.html
+ <div class="contribute-copy">
+ <h1 class="text-uppercase contribute-item">Become a part of it!</h1>
+ <p class="contribute-item">
+ With your support you'll help us cover all the expenses the collective needs to keep going!
@phated
phated Jan 9, 2017 Member

This should probably say "all the expenses our project needs"

img/gulp-white-logo.svg
+ <title>gulp-white-logo</title>
+ <desc>Created with Sketch.</desc>
+ <defs></defs>
+ <g id="Page-1" stroke="none" stroke-width="1" fill="none" fill-rule="evenodd">
@phated
phated Jan 9, 2017 Member

We weren't sure how id works with SVG so we've been removing them.

@contra

LGTM - couple of small copy changes and I'll merge.

Can you also remove the donate button from the header since we're adding this?

index.html
+ <img class="logo-img-lg" src="img/gulp-white-logo.svg">
+ </div>
+ <div class="contribute-copy">
+ <h1 class="text-uppercase contribute-item">Become a part of it!</h1>
@contra
contra Jan 9, 2017 Member

"Become a contributor!"

index.html
+ <div class="contribute-copy">
+ <h1 class="text-uppercase contribute-item">Become a part of it!</h1>
+ <p class="contribute-item">
+ With your support you'll help us cover all the expenses our project needs to keep going!
@contra
contra Jan 9, 2017 Member

"With your support, you can help us cover expenses and keep the project going strong."

index.html
+ With your support you'll help us cover all the expenses our project needs to keep going!
+ </p>
+ <a class="ctas-button contribute-item"
+ href="https://opencollective.com/gulpjs">Become a backer or sponsor</a>
@contra
contra Jan 9, 2017 Member

"Become a backer"

Not really useful to delineate since the page they'll go to has more info.

@bdougie
Contributor
bdougie commented Jan 10, 2017

copy changes made @contra, also thanks for the opportunity 🙌🏾

@contra contra merged commit 1c43630 into gulpjs:master Jan 10, 2017
@contra
Member
contra commented Jan 10, 2017

@bdougie Thanks! Should be live in a second.

@phated phated referenced this pull request Jan 10, 2017
Closed

Contribute Section #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment