New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docusaurus Docs Management #78

Closed
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@SomethingNew71
Contributor

SomethingNew71 commented Jan 3, 2018

Work In Progress

Decided to get the PR started so you could see where I am at so far with this and provide input as needed. I ported over the docs from the main gulp repo to set this up and have started with the configuration. I have run into some funny business that appears to be a limitation of GitBooks. You cannot directly link to readmes unless they exist in the left navigation. That means all those recipes will need to be added to the left nav manually before they can be linked to.

Otherwise, it's working quite well!

Resolves issue #31

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Jan 3, 2018

Member

Neat! Can't wait to check this out tomorrow or Thursday

Member

phated commented Jan 3, 2018

Neat! Can't wait to check this out tomorrow or Thursday

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Jan 4, 2018

Member

@SomethingNew71 am I missing something or is there no theme yet?

Member

phated commented Jan 4, 2018

@SomethingNew71 am I missing something or is there no theme yet?

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Jan 4, 2018

Member

We'll need to add something that fetches the docs from the main repo because I'm not going to have those checked into both repos.

Member

phated commented Jan 4, 2018

We'll need to add something that fetches the docs from the main repo because I'm not going to have those checked into both repos.

@SomethingNew71

This comment has been minimized.

Show comment
Hide comment
@SomethingNew71

SomethingNew71 Jan 4, 2018

Contributor

The theme is installed from what I can see. This was the theme you wanted right?

The two column layout is only used when declaring different language setup instructions. If you have a single language or multiple languages listed on one page the two column visual display breaks, unfortunately.

I can work something up that will fetch that info from GitHub. That would be quite a headache updating both places manually.

Would you be alright with something you run locally to grab updated content and then you can compile the book after grabbing new content?

Contributor

SomethingNew71 commented Jan 4, 2018

The theme is installed from what I can see. This was the theme you wanted right?

The two column layout is only used when declaring different language setup instructions. If you have a single language or multiple languages listed on one page the two column visual display breaks, unfortunately.

I can work something up that will fetch that info from GitHub. That would be quite a headache updating both places manually.

Would you be alright with something you run locally to grab updated content and then you can compile the book after grabbing new content?

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Jan 4, 2018

Member

@SomethingNew71 I'm looking for someone to create a theme for us. One that works with our main website theme (red colors, etc).

Member

phated commented Jan 4, 2018

@SomethingNew71 I'm looking for someone to create a theme for us. One that works with our main website theme (red colors, etc).

@SomethingNew71

This comment has been minimized.

Show comment
Hide comment
@SomethingNew71

SomethingNew71 Jan 4, 2018

Contributor

Derp! I definitely misunderstood that. I can still do that though. 😄

Contributor

SomethingNew71 commented Jan 4, 2018

Derp! I definitely misunderstood that. I can still do that though. 😄

@SomethingNew71

This comment has been minimized.

Show comment
Hide comment
@SomethingNew71

SomethingNew71 Jan 8, 2018

Contributor

@phated just a heads up I was going to get more done this weekend but was slammed with my day job. I should have updates for you this week. Sorry for the delay!

Contributor

SomethingNew71 commented Jan 8, 2018

@phated just a heads up I was going to get more done this weekend but was slammed with my day job. I should have updates for you this week. Sorry for the delay!

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Jan 8, 2018

Member

Thanks for the update - looking forward to the new theme

Member

phated commented Jan 8, 2018

Thanks for the update - looking forward to the new theme

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Jan 15, 2018

Member

@SomethingNew71 I just found https://github.com/facebook/Docusaurus - it looks awesome and I think the colors are configurable on the default template. What do you think about using that?

Member

phated commented Jan 15, 2018

@SomethingNew71 I just found https://github.com/facebook/Docusaurus - it looks awesome and I think the colors are configurable on the default template. What do you think about using that?

@SomethingNew71

This comment has been minimized.

Show comment
Hide comment
@SomethingNew71

SomethingNew71 Jan 15, 2018

Contributor

@phated oh this is nice! You think this instead of gitbook? The more and more I dig into Gitbook the more its looking like its semi-abandoned in the "install it yourself" arena. Most of the support targets their paid tiers and hosted options.

Contributor

SomethingNew71 commented Jan 15, 2018

@phated oh this is nice! You think this instead of gitbook? The more and more I dig into Gitbook the more its looking like its semi-abandoned in the "install it yourself" arena. Most of the support targets their paid tiers and hosted options.

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Jan 15, 2018

Member

Yeah, I think Docusaurus would be better. It looks way better than gitbook by default so we won't need a custom template.

Member

phated commented Jan 15, 2018

Yeah, I think Docusaurus would be better. It looks way better than gitbook by default so we won't need a custom template.

@SomethingNew71

This comment has been minimized.

Show comment
Hide comment
@SomethingNew71

SomethingNew71 Jan 15, 2018

Contributor

Question though, do you have any thoughts on how you want the docs content pulled in? It still requires a local copy of the markdown files in the repo where the docs live.

Contributor

SomethingNew71 commented Jan 15, 2018

Question though, do you have any thoughts on how you want the docs content pulled in? It still requires a local copy of the markdown files in the repo where the docs live.

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Jan 15, 2018

Member

We'll probably use a curl type command into a local directory and gitignore the raw markdown. Then we can only commit the generated pages.

Member

phated commented Jan 15, 2018

We'll probably use a curl type command into a local directory and gitignore the raw markdown. Then we can only commit the generated pages.

@SomethingNew71

This comment has been minimized.

Show comment
Hide comment
@SomethingNew71

SomethingNew71 Jan 16, 2018

Contributor

@phated I just pushed up an initial commit still a work in progress, but I wanted you to be able to take a look at it. I am still skeptical about our ability to curl in the docs since each doc file needs to be manipulated in name and in content to get it to work with the Docusaurus pattern. I have only converted the Getting Started file and the first 3 recipe files. Notice the ID and naming content at the top of each of those files.

Contributor

SomethingNew71 commented Jan 16, 2018

@phated I just pushed up an initial commit still a work in progress, but I wanted you to be able to take a look at it. I am still skeptical about our ability to curl in the docs since each doc file needs to be manipulated in name and in content to get it to work with the Docusaurus pattern. I have only converted the Getting Started file and the first 3 recipe files. Notice the ID and naming content at the top of each of those files.

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Jan 16, 2018

Member

@SomethingNew71 ooooo, looking at the config files, we might be able to automate this. I'll have a better chance to look at this Tues/Weds.

Member

phated commented Jan 16, 2018

@SomethingNew71 ooooo, looking at the config files, we might be able to automate this. I'll have a better chance to look at this Tues/Weds.

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Jan 16, 2018

Member

I think we could wrap the headers in a comment and strip it during the build process.

Member

phated commented Jan 16, 2018

I think we could wrap the headers in a comment and strip it during the build process.

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Jan 16, 2018

Member

@SomethingNew71 I made something 55eba76 - if you work from the "pull-docs" branch, you can install that dep and run npm run docs and it'll fetch the docs into the project. Still more work to be done but it is a start.

(Needs node 8+)

Member

phated commented Jan 16, 2018

@SomethingNew71 I made something 55eba76 - if you work from the "pull-docs" branch, you can install that dep and run npm run docs and it'll fetch the docs into the project. Still more work to be done but it is a start.

(Needs node 8+)

@SomethingNew71

This comment has been minimized.

Show comment
Hide comment
@SomethingNew71

SomethingNew71 Jan 16, 2018

Contributor

Nice! I'll pull it down tomorrow as I will have some time to take a look tomorrow AM. Thanks!

Contributor

SomethingNew71 commented Jan 16, 2018

Nice! I'll pull it down tomorrow as I will have some time to take a look tomorrow AM. Thanks!

@SomethingNew71

This comment has been minimized.

Show comment
Hide comment
@SomethingNew71

SomethingNew71 Jan 21, 2018

Contributor

This works great. Now we just need to process the downloaded raw ones with a banner and pull them out of the nested locations in their raw state. Also I noticed /docs was added to the .gitignore which won't work. That directory needs to be tracked for Docusaurus to work. Do you want me to write a little gulp thing to process those readmes?

I am sure we can programmatically add a banner to those that will work for this.

Contributor

SomethingNew71 commented Jan 21, 2018

This works great. Now we just need to process the downloaded raw ones with a banner and pull them out of the nested locations in their raw state. Also I noticed /docs was added to the .gitignore which won't work. That directory needs to be tracked for Docusaurus to work. Do you want me to write a little gulp thing to process those readmes?

I am sure we can programmatically add a banner to those that will work for this.

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Jan 22, 2018

Member

@SomethingNew71 I was going to look into putting the front-matter stuff into an HTML comment inside the markdown files then removing the comments before running docusaurus. I haven't had a chance to look into existing modules yet but maybe @jonschlinkert or @doowb have/know of a project that can do that?

Member

phated commented Jan 22, 2018

@SomethingNew71 I was going to look into putting the front-matter stuff into an HTML comment inside the markdown files then removing the comments before running docusaurus. I haven't had a chance to look into existing modules yet but maybe @jonschlinkert or @doowb have/know of a project that can do that?

@doowb

This comment has been minimized.

Show comment
Hide comment
@doowb

doowb Jan 23, 2018

Member

@phated you can use gray-matter and do something like this in a task:

const gulp = require('gulp');
const through = require('through2');
const matter = require('gray-matter');

gulp.task('default', () => {
  return gulp.src('docs/*.md')
    .pipe(through.obj((file, enc, next) => {
      file = matter(file, {delimiters: ['<!-- front-matter', '-->']});
      file.contents = new Buffer(file.stringify());
      next(null, file);
    }))
    .pipe(gulp.dest('dist'));
});

Then in the markdown file you can specify your front matter with the html comments that are used as delimiters:

<!-- front-matter
title: Test 1
-->
## Markdown

> some regular markdown stuff

These will get converted into:

---
title: Test 1
---
## Markdown

> some regular markdown stuff
Member

doowb commented Jan 23, 2018

@phated you can use gray-matter and do something like this in a task:

const gulp = require('gulp');
const through = require('through2');
const matter = require('gray-matter');

gulp.task('default', () => {
  return gulp.src('docs/*.md')
    .pipe(through.obj((file, enc, next) => {
      file = matter(file, {delimiters: ['<!-- front-matter', '-->']});
      file.contents = new Buffer(file.stringify());
      next(null, file);
    }))
    .pipe(gulp.dest('dist'));
});

Then in the markdown file you can specify your front matter with the html comments that are used as delimiters:

<!-- front-matter
title: Test 1
-->
## Markdown

> some regular markdown stuff

These will get converted into:

---
title: Test 1
---
## Markdown

> some regular markdown stuff
@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Jan 23, 2018

Member

@doowb that worked out great! Thanks!

@SomethingNew71 I've pushed a really simple gulpfile to the pull-docs branch that adds the front-matter conversion logic. It does an in-place transform on the markdown files.

Member

phated commented Jan 23, 2018

@doowb that worked out great! Thanks!

@SomethingNew71 I've pushed a really simple gulpfile to the pull-docs branch that adds the front-matter conversion logic. It does an in-place transform on the markdown files.

@phated phated changed the title from GitBooks Docs Management to Docusaurus Docs Management Jan 23, 2018

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Jan 23, 2018

Member

I've created a wip-docs branch on the main gulp repo so we can work on docs away from master. I also updated the build script to fetch that branch.

Member

phated commented Jan 23, 2018

I've created a wip-docs branch on the main gulp repo so we can work on docs away from master. I also updated the build script to fetch that branch.

@SomethingNew71

This comment has been minimized.

Show comment
Hide comment
@SomethingNew71

SomethingNew71 Jan 25, 2018

Contributor

Awesome this should be perfect. I'll work something up tonight and I should be able to update this PR with a working instance with your docs.

Contributor

SomethingNew71 commented Jan 25, 2018

Awesome this should be perfect. I'll work something up tonight and I should be able to update this PR with a working instance with your docs.

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Jan 26, 2018

Member

@SomethingNew71 great, ping me when you have something 😸

Member

phated commented Jan 26, 2018

@SomethingNew71 great, ping me when you have something 😸

@SomethingNew71

This comment has been minimized.

Show comment
Hide comment
@SomethingNew71

SomethingNew71 Jan 28, 2018

Contributor

@phated do I need to be passing any arguments to the default gulp task? Unless I'm missing something it is not building the comments properly.

Contributor

SomethingNew71 commented Jan 28, 2018

@phated do I need to be passing any arguments to the default gulp task? Unless I'm missing something it is not building the comments properly.

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Jan 28, 2018

Member

@SomethingNew71 just submit a PR against the wip-docs branch. I can put together a sample if you need any guidance.

Member

phated commented Jan 28, 2018

@SomethingNew71 just submit a PR against the wip-docs branch. I can put together a sample if you need any guidance.

@SomethingNew71

This comment has been minimized.

Show comment
Hide comment
@SomethingNew71

SomethingNew71 Jan 28, 2018

Contributor

@phated yeah, I wouldn't mind a sample just in case. I know what Docusaurus requires but I want to make sure I am doing it the way you want it as well.

Contributor

SomethingNew71 commented Jan 28, 2018

@phated yeah, I wouldn't mind a sample just in case. I know what Docusaurus requires but I want to make sure I am doing it the way you want it as well.

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Jan 28, 2018

Member

@SomethingNew71 submitted a PR to gulp and cc'd you.

Member

phated commented Jan 28, 2018

@SomethingNew71 submitted a PR to gulp and cc'd you.

delimiters: ['<!-- front-matter', '-->']
};
function fetchDocs() {

This comment has been minimized.

@SomethingNew71

SomethingNew71 Feb 1, 2018

Contributor

@phated Question Part 1: So here is my question. I see where you are fetching the docs from wip-docs. But they come through from Github with what appears to be no front-matter like I added on all the files. Perhaps that's a bug?

@SomethingNew71

SomethingNew71 Feb 1, 2018

Contributor

@phated Question Part 1: So here is my question. I see where you are fetching the docs from wip-docs. But they come through from Github with what appears to be no front-matter like I added on all the files. Perhaps that's a bug?

This comment has been minimized.

@phated

phated Feb 1, 2018

Member

Looks like there's a bug. Looking into it.

@phated

phated Feb 1, 2018

Member

Looks like there's a bug. Looking into it.

Show outdated Hide outdated gulpfile.js Outdated
@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Feb 1, 2018

Member

@SomethingNew71 can you gitignore the markdown files but keep the .html files?

Member

phated commented Feb 1, 2018

@SomethingNew71 can you gitignore the markdown files but keep the .html files?

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Feb 1, 2018

Member

@SomethingNew71 I've updated the https://github.com/gulpjs/gulpjs.github.io/commits/pull-docs branch with the bug fixes. Please make sure you get the 1.1.1 version of github-download-directory when you reinstall (I noticed you added a package-lock file which would cause problems)

Member

phated commented Feb 1, 2018

@SomethingNew71 I've updated the https://github.com/gulpjs/gulpjs.github.io/commits/pull-docs branch with the bug fixes. Please make sure you get the 1.1.1 version of github-download-directory when you reinstall (I noticed you added a package-lock file which would cause problems)

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Feb 3, 2018

Member

@SomethingNew71 how's it going? I believe I fixed the issue - let me know if it still isn't working.

Member

phated commented Feb 3, 2018

@SomethingNew71 how's it going? I believe I fixed the issue - let me know if it still isn't working.

@SomethingNew71

This comment has been minimized.

Show comment
Hide comment
@SomethingNew71

SomethingNew71 Feb 3, 2018

Contributor

@phated sorry I thought I hit submit when I wrote my response but I guess I didn't. Looking good and is working properly now. I am finalizing some additions to the gulp tasks you made and should have something before Monday. 😄 Also, I will gitignore the docs folder. Forgot it outputs the base HTML after it builds.

Contributor

SomethingNew71 commented Feb 3, 2018

@phated sorry I thought I hit submit when I wrote my response but I guess I didn't. Looking good and is working properly now. I am finalizing some additions to the gulp tasks you made and should have something before Monday. 😄 Also, I will gitignore the docs folder. Forgot it outputs the base HTML after it builds.

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Feb 4, 2018

Member

@SomethingNew71 nice! I didn't realize that it was actually react components they spit out. That's pretty neat because we can hack them to pieces if we need 😛

I think that API is going to become a sidebar item instead of topbar (if I'm reading that right) and then we'll split each API method into it's own markdown file/page.

Member

phated commented Feb 4, 2018

@SomethingNew71 nice! I didn't realize that it was actually react components they spit out. That's pretty neat because we can hack them to pieces if we need 😛

I think that API is going to become a sidebar item instead of topbar (if I'm reading that right) and then we'll split each API method into it's own markdown file/page.

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Feb 4, 2018

Member

@SomethingNew71 I know it's still a WIP but there's a bunch of problems when running the server. I believe it's due to the id properties you added to the markdown files not matching the ones you reference in the config files (and it looks like uppercase/lowercase matters).

Member

phated commented Feb 4, 2018

@SomethingNew71 I know it's still a WIP but there's a bunch of problems when running the server. I believe it's due to the id properties you added to the markdown files not matching the ones you reference in the config files (and it looks like uppercase/lowercase matters).

@SomethingNew71

This comment has been minimized.

Show comment
Hide comment
@SomethingNew71

SomethingNew71 Feb 4, 2018

Contributor

Confirmed that's actually the step I am hoping to automate. I am hoping to make it auto-generate that file based on the data in the markdown files when the files are fetched.

Contributor

SomethingNew71 commented Feb 4, 2018

Confirmed that's actually the step I am hoping to automate. I am hoping to make it auto-generate that file based on the data in the markdown files when the files are fetched.

@SomethingNew71

This comment has been minimized.

Show comment
Hide comment
@SomethingNew71

SomethingNew71 Feb 6, 2018

Contributor

@phated Update added to get a working prototype up and running. Give it a pull and take a look. I think it's coming together. I was super busy this weekend unexpectedly so I did not get to add the automation in I wanted but it's shaping up now. I need to populate the social links and clean up some of the styles.

Have a look at the user's page, you can add some good info about who uses gulp on that page. Wasn't sure who your team would want to include there.

Contributor

SomethingNew71 commented Feb 6, 2018

@phated Update added to get a working prototype up and running. Give it a pull and take a look. I think it's coming together. I was super busy this weekend unexpectedly so I did not get to add the automation in I wanted but it's shaping up now. I need to populate the social links and clean up some of the styles.

Have a look at the user's page, you can add some good info about who uses gulp on that page. Wasn't sure who your team would want to include there.

Show outdated Hide outdated gulpfile.js Outdated
@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Feb 15, 2018

Member

I've just figured out a (very depressing) way to avoid the duplicate titles that we're getting due to having headings in the markdown documents.

I used the following remarkable plugin:

function commentOutHeading(md) {
  var ogHeadingOpen = md.renderer.rules.heading_open;
  var ogHeadingClose = md.renderer.rules.heading_close;

  var waitingForClose = false;

  md.renderer.rules.heading_open = function(tokens, idx /*, options, env */) {
    if (tokens[idx].hLevel === 1 && idx === 0) {
      waitingForClose = true;
      return '<!-- ';
    }
    return ogHeadingOpen.apply(this, arguments);
  };

  md.renderer.rules.heading_close = function(tokens, idx /*, options, env */) {
    if (tokens[idx].hLevel === 1 && waitingForClose) {
      waitingForClose = false;
      return ' -->';
    }
    return ogHeadingClose.apply(this, arguments);
  };
}
Member

phated commented Feb 15, 2018

I've just figured out a (very depressing) way to avoid the duplicate titles that we're getting due to having headings in the markdown documents.

I used the following remarkable plugin:

function commentOutHeading(md) {
  var ogHeadingOpen = md.renderer.rules.heading_open;
  var ogHeadingClose = md.renderer.rules.heading_close;

  var waitingForClose = false;

  md.renderer.rules.heading_open = function(tokens, idx /*, options, env */) {
    if (tokens[idx].hLevel === 1 && idx === 0) {
      waitingForClose = true;
      return '<!-- ';
    }
    return ogHeadingOpen.apply(this, arguments);
  };

  md.renderer.rules.heading_close = function(tokens, idx /*, options, env */) {
    if (tokens[idx].hLevel === 1 && waitingForClose) {
      waitingForClose = false;
      return ' -->';
    }
    return ogHeadingClose.apply(this, arguments);
  };
}
@SomethingNew71

This comment has been minimized.

Show comment
Hide comment
@SomethingNew71

SomethingNew71 Feb 22, 2018

Contributor

I really need to fix my GitHub notification settings. Had no idea these had come through. 😒 I'll pull your changes down and get some updates to you with a functioning site.

Contributor

SomethingNew71 commented Feb 22, 2018

I really need to fix my GitHub notification settings. Had no idea these had come through. 😒 I'll pull your changes down and get some updates to you with a functioning site.

@SomethingNew71

This comment has been minimized.

Show comment
Hide comment
@SomethingNew71

SomethingNew71 Mar 4, 2018

Contributor

Hey, @phated I am diving back into this today and I had a question. The comment above with the fix using remarkable. Did you implement this somewhere? I am getting those duplicated still but your comment makes it sound like this was already included somewhere.

Contributor

SomethingNew71 commented Mar 4, 2018

Hey, @phated I am diving back into this today and I had a question. The comment above with the fix using remarkable. Did you implement this somewhere? I am getting those duplicated still but your comment makes it sound like this was already included somewhere.

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Mar 4, 2018

Member

I thought I committed it but maybe I didn't push it. I'll check in a little bit

Member

phated commented Mar 4, 2018

I thought I committed it but maybe I didn't push it. I'll check in a little bit

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Mar 4, 2018

Member

@SomethingNew71 I was in the middle of a cherry-pick, I guess 😛 I've pushed the changes at https://github.com/gulpjs/gulpjs.github.io/commits/docs which contains a cherry-pick of the new pull-docs changes and the markdown hacks.

Member

phated commented Mar 4, 2018

@SomethingNew71 I was in the middle of a cherry-pick, I guess 😛 I've pushed the changes at https://github.com/gulpjs/gulpjs.github.io/commits/docs which contains a cherry-pick of the new pull-docs changes and the markdown hacks.

@SomethingNew71

This comment has been minimized.

Show comment
Hide comment
@SomethingNew71

SomethingNew71 Mar 11, 2018

Contributor

Hey @phated I feel like I have a good working site for you to take a look at now. Have a look at the recently uploaded content and let me know what you think. I wasn't sure what content you would want to add on the 'Welcome Page" so if you want more copy, or something just let me know what you want there and I can get it added.

Contributor

SomethingNew71 commented Mar 11, 2018

Hey @phated I feel like I have a good working site for you to take a look at now. Have a look at the recently uploaded content and let me know what you think. I wasn't sure what content you would want to add on the 'Welcome Page" so if you want more copy, or something just let me know what you want there and I can get it added.

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Mar 11, 2018

Member

@SomethingNew71 can we get rid of the Welcome Page? I'd like to just link to the docs page from our homepage.

Member

phated commented Mar 11, 2018

@SomethingNew71 can we get rid of the Welcome Page? I'd like to just link to the docs page from our homepage.

@SomethingNew71

This comment has been minimized.

Show comment
Hide comment
@SomethingNew71

SomethingNew71 Mar 11, 2018

Contributor

Probably, I don't see why it would be a problem. Let me take a look after work tonight.

Contributor

SomethingNew71 commented Mar 11, 2018

Probably, I don't see why it would be a problem. Let me take a look after work tonight.

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Apr 16, 2018

Member

Looks like someone else had our "hide title" problem and fixed it: facebook/Docusaurus@6dd6ead

Member

phated commented Apr 16, 2018

Looks like someone else had our "hide title" problem and fixed it: facebook/Docusaurus@6dd6ead

@SomethingNew71

This comment has been minimized.

Show comment
Hide comment
@SomethingNew71

SomethingNew71 Apr 16, 2018

Contributor

Oh nice. Would you like me to integrate that into this dev branch?

Contributor

SomethingNew71 commented Apr 16, 2018

Oh nice. Would you like me to integrate that into this dev branch?

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Apr 17, 2018

Member

@SomethingNew71 we've decided to move this code into it's own repo so I've merged this at gulpjs/old-docs-repo@ccc4eed

Thanks for all the hard work on this!

Member

phated commented Apr 17, 2018

@SomethingNew71 we've decided to move this code into it's own repo so I've merged this at gulpjs/old-docs-repo@ccc4eed

Thanks for all the hard work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment