-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement default configuration where possible #83
Conversation
@sttk what do you think of this approach? Will it cause users to be confused? |
@phated I forget the inside of |
@phated I think that this is good idea, but I'm worried that there are no way that user changes this default configuration because it is inside a function.
|
@sttk thank you! I like your idea but I want to think of the best way to implement it. |
637d2e0
to
2cd9efb
Compare
@sttk I adjusted your idea slightly, but I like how this turned out! Now, a consumer can pass any Overriding the default config is a very advanced technique, so I'm only documenting it a tiny bit. |
I'm going to merge this, but will plan to cut the 3.0.0 release in the next couple of days. Please let me know if you see anything bad about this! |
feat: Allow register function configuration to be overridden
This was a random idea I had while working on this package. Why do we require people to configure their require hooks? We can (mostly) do that for them when we load the hook. Many of the hooks I researched allow you to pass any options when calling the register function.
This PR demonstrates the things we could override by default. Looking for thoughts about the overall idea.