Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade scaffold and introduce Github Action #40

Merged
merged 9 commits into from Jul 24, 2021
Merged

Conversation

sttk
Copy link
Member

@sttk sttk commented Apr 4, 2021

I modified this project referring to replace-ext.

@@ -1,4 +1,15 @@
## Security contact information
# Security Policy
Copy link
Member

@phated phated Apr 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sttk I added a "global" security policy to the gulpjs github organization, so we can probably remove this file.

Copy link
Member Author

@sttk sttk Jun 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I'll remove this file.

README.md Outdated Show resolved Hide resolved
test/index.js Outdated

it('should register a module loader for the specified extension with cwd', function(done) {
Copy link
Member

@phated phated Apr 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New test?

Copy link
Member Author

@sttk sttk Jun 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. there was no case about cwd option and this case make coverage to 100%.

@sttk
Copy link
Member Author

sttk commented Jun 12, 2021

@phated I'm sorry for too late reply. I modified what you pointed out.

@phated
Copy link
Member

phated commented Jul 20, 2021

I'm going to make some more changes to the scaffold and apply to this repository. I will probably apply them to this PR and then merge it.

@phated phated merged commit 00f5968 into gulpjs:master Jul 24, 2021
27 checks passed
This was referenced Jul 24, 2021
@phated
Copy link
Member

phated commented Jul 24, 2021

Thanks @sttk! I'm going to be releasing 0.8.0 shortly. I appreciate your work here 🍻

@sttk sttk deleted the upgrading branch Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants