Bind #9
Merged
Bind #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
|
Ah yes, that looks much nicer! Not sure why I didn't think of avoiding the problem of binding a function arg (type in this case) but not its context -- which is why I didn't think the built-in short-cuts would work -- simply by virtue of not binding at all but just wrapping the call in a new function instead... |
Member
Author
|
Cool. I think I'll consider this a breaking change. Do you want to submit changes for #8 based on my comment and we can ship them both as 3.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@erikkemperman Updated your concept. I think this is a lot cleaner than adding a
bindmethod, as it just uses language features.(Btw, do you have push access to this repo? I wanted to just updated your PR but you weren't working on a branch in the repo.)