Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing options parameter in copy #22

Closed
Jineapple opened this issue Aug 8, 2019 · 2 comments

Comments

@Jineapple
Copy link

commented Aug 8, 2019

In line 3027 of filesystem.hpp, if the copy()-method resolves to a copy_file with two file paths given, the options parameter is not passed on.
copy_file(from, to, ec);
This causes issues e.g. if the target file already exists and overwrite_existing or update_existing was passed as an option.

@gulrak gulrak added bug high labels Aug 8, 2019

@gulrak gulrak self-assigned this Aug 8, 2019

@gulrak gulrak added this to the v1.2.4 milestone Aug 8, 2019

@gulrak

This comment has been minimized.

Copy link
Owner

commented Aug 8, 2019

Thanks for finding it! I will push a fix to master today, and scheduled a release for the weekend.

gulrak added a commit that referenced this issue Aug 9, 2019

@gulrak

This comment has been minimized.

Copy link
Owner

commented Aug 11, 2019

Fix released with v1.2.4

@gulrak gulrak closed this Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.