Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeclared identifier DWORD #39

Closed
Mooseart opened this issue Nov 18, 2019 · 2 comments
Closed

Undeclared identifier DWORD #39

Mooseart opened this issue Nov 18, 2019 · 2 comments
Assignees
Milestone

Comments

@Mooseart
Copy link

@Mooseart Mooseart commented Nov 18, 2019

Hi.
Believe I've found a bug:
Error C2065 'DWORD': undeclared identifier ghc\filesystem.hpp(1089)

Noticed this now (on Windows, vs2019) when upgrading from an older release of your repo.

So I get this when using the forward declarations. Apparently it now relies on having DWORD already defined which wasn't the case before. My application does not include windows.h, hence there's no DWORD.

I see a few options:

  • Change the declaration of make_system_error() to not use DWORD.
  • Include windows.h always, not only for implementation.
  • typedef unsigned long DWORD if not already defined.

Not sure what works best here but the latter two are probably best to avoid if possible.

@gulrak gulrak self-assigned this Nov 20, 2019
@gulrak

This comment has been minimized.

Copy link
Owner

@gulrak gulrak commented Nov 20, 2019

Thanks for the report! I'll look into it, was a few days and got back with an annoying cold.

@gulrak gulrak added the bug label Nov 22, 2019
gulrak added a commit that referenced this issue Nov 22, 2019
…to trigger an error if there is a dependency to windows.h
@gulrak gulrak added this to the v1.2.10 milestone Nov 22, 2019
@gulrak

This comment has been minimized.

Copy link
Owner

@gulrak gulrak commented Nov 24, 2019

Fix released with v1.2.10

@gulrak gulrak closed this Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.