Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler warnings #44

Closed
ruipacheco opened this issue Dec 21, 2019 · 2 comments
Closed

Compiler warnings #44

ruipacheco opened this issue Dec 21, 2019 · 2 comments
Assignees
Milestone

Comments

@ruipacheco
Copy link

@ruipacheco ruipacheco commented Dec 21, 2019

Is your feature request related to a problem? Please describe.
Not a problem, just some compiler warnings I got in the latest macOS with the latest Xcode.

Describe the solution you'd like
Comment and possibly act on these:

filesystem.hpp:3561:44: warning: zero as null pointer constant [-Wzero-as-null-pointer-constant]
if (::getcwd(buffer.get(), pathlen) == NULL) {
^~~~
nullptr

filesystem.hpp:2559:12: note: call 'std::move' explicitly to avoid copying on older compilers
return fn;
^~
std::move(fn)

filesystem.hpp:2559:12: warning: prior to the resolution of a defect report against ISO C++11, local variable 'fn' would have been copied despite being returned by name, due to its not matching the function return type ('ghc::filesystem::path' vs 'ghc::filesystem::path::impl_string_type' (aka 'basic_string')) [-Wreturn-std-move-in-c++11]
return fn;
^~

@gulrak gulrak self-assigned this Dec 21, 2019
@gulrak gulrak added low macOS labels Dec 21, 2019
@gulrak

This comment has been minimized.

Copy link
Owner

@gulrak gulrak commented Dec 21, 2019

I didn't switch to the latest Xcode yet, but of course I want to stay warning free where possible, so I'll sure look into it. Thank you for reporting this!

@gulrak gulrak added this to the v1.2.12 milestone Dec 21, 2019
gulrak added a commit that referenced this issue Dec 21, 2019
gulrak added a commit that referenced this issue Dec 21, 2019
@gulrak gulrak modified the milestones: v1.2.12, 1.3.0 Feb 7, 2020
@gulrak

This comment has been minimized.

Copy link
Owner

@gulrak gulrak commented Feb 8, 2020

Released with v1.3.0.

@gulrak gulrak closed this Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.