Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export as target #24

Merged
merged 1 commit into from Sep 29, 2019
Merged

export as target #24

merged 1 commit into from Sep 29, 2019

Conversation

@JonasVautherin
Copy link
Contributor

JonasVautherin commented Aug 13, 2019

This is trying to export ghc-filesystem as a target, so you can include it with ghcFilesystem::ghc_filesystem in cmake projects.

I am not completely sure if I broke something that was existing before, but it seems to be working for me. Let me know what you think.

CMakeLists.txt Outdated Show resolved Hide resolved
@gulrak

This comment has been minimized.

Copy link
Owner

gulrak commented Aug 15, 2019

Sorry that I din't react on this one yet. I need to look further into this, as I don't currently use the feature myself and it already came from a PR (#14) from @fenglc, so I want to at least check the impact on some configurations.

CMakeLists.txt Outdated Show resolved Hide resolved
@panquez

This comment has been minimized.

Copy link

panquez commented Aug 20, 2019

Any update on this PR? Thank you all

@gulrak

This comment has been minimized.

Copy link
Owner

gulrak commented Sep 27, 2019

I'll look into this this weekend. Sorry it takes so long.

@gulrak gulrak merged commit 65b5409 into gulrak:master Sep 29, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 96.013%
Details
@gulrak

This comment has been minimized.

Copy link
Owner

gulrak commented Sep 29, 2019

Finally, thanks for the PR and sorry for the long delay.

@JonasVautherin JonasVautherin deleted the JonasVautherin:export-target branch Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.