Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HanjaComposer와 EmoticonComposer 합치기 #637

Closed
youknowone opened this issue Sep 29, 2019 · 2 comments

Comments

@youknowone
Copy link
Member

commented Sep 29, 2019

처음 만들때는 한글/로마자 처리를 따로 해야해서 나눠 놨는데, 같은 일을 하는 코드가 중복이어서 결국 합쳐야 할 것 같습니다

모드 전환할때

  • 레퍼런스할 원 입력기(한글 or 로마자)
  • 검색할 후보 영역(한자/이모티콘 등)

을 넘겨서 검색하게 만들면 두 composer가 구분될 필요가 없어 보입니다

@presto95

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2019

🙌

@yous

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

@youknowone youknowone closed this Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.