Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

이모티콘 입력기 검색 방식 변경 #643

Merged
merged 8 commits into from Oct 6, 2019

Conversation

@JimJeon
Copy link
Contributor

commented Sep 29, 2019

기존의 prefix search 방식에서 fuzzy search 방식으로 변경함

JimJeon added 4 commits Sep 29, 2019
Previous:
    `table.hanjas(byPrefixSearching: )` in libhangul

Current:
    fuzzy searching with `Fuse` library
@yous

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

리베이스 한 번 하면 swiftformat 관련한 커밋을 줄일 수 있을 것 같은데요, gureum/gureum을 upstream remote에 지정해두셨다면:

git fetch upstream
git rebase upstream/master
git push --force-with-lease

한 번 해주시면 될 것 같습니다.

break
}
for result in searchResult {
let emoticonLine: String = table[result.index]

This comment has been minimized.

Copy link
@youknowone

youknowone Oct 1, 2019

Member

여기 들어가는 데이터가 어떻게 생겼어요?

let emoticonLine: String = table[result.index]
let emoticon: String = String(emoticonLine.split(separator: ":")[1])
let comment: String = String(emoticonLine.split(separator: ":")[0])
_candidates!.append(NSAttributedString(string: emoticon + ": " + comment))

This comment has been minimized.

Copy link
@youknowone

youknowone Oct 1, 2019

Member

데이터가 많으니 잘랐다 다시 붙이는 걸 피해야 할것 같아요. 원본 데이터를 '값: 키워드' 형태로 두면 문자열 연산 없이 그대로 쓸수도 있을거고, 당장 원본 고치는게 어려우면 (한자랑 호환되는 형태죠?) 여기서 잘랐다 붙이는게 아니라 HanjaTable.emoji 만들때 가공해 두고 여기서는 그대로 쓸 수 있게 해야겠습니다

This comment has been minimized.

Copy link
@JimJeon

JimJeon Oct 1, 2019

Author Contributor

그렇네요 굳이 여기서 수정하지 않고 미리 로드할 때 가공하는게 나을 거 같네요!
sleepy face:(emo):sleepy face -> (emo): sleepy face로 로드하도록 바꿔볼께요

@JimJeon

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

@yous 넵 리베이스 한 번 해서 커밋하겠습니다

@youknowone

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

#646 을 먼저 머지하면서 conflict가 크게 났네요

@JimJeon

This comment has been minimized.

Copy link
Contributor Author

commented Oct 6, 2019

!!!! Conflict 수정하겠습니다...

@youknowone youknowone merged commit ba01bbb into gureum:master Oct 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@youknowone

This comment has been minimized.

Copy link
Member

commented Oct 6, 2019

큰 변경이 자꾸 깨지는걸 막기 위해 먼저 머지하겠습니다. 성능 관련 이슈는 꼭 해결해야 할거 같아요

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.