Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

이모지 단축키 삭제하고 한자 단축키와 통합 외 #652

Merged
merged 3 commits into from Oct 5, 2019

Conversation

@presto95
Copy link
Contributor

presto95 commented Oct 4, 2019

  • 이모지 단축키 설정값이 더 이상 사용되지 않으므로 삭제하고 한자 단축키와 통합 / 관련 코드 수정
  • Preferences.swift 파일에 있는 클래스나 익스텐션을 별도 파일로 분리
  • boolToButtonState(_:) -> isOn(_:)
  • getShortcut(forKey:) -> shortcut(forKey:)

#595 이슈 해결 단서를 찾아보다가 한번 고쳐보았습니다. Preferences 쪽에는 단서가 없을 것 같은데..

Copy link
Member

youknowone left a comment

변경하고 나서 install_debug 후에 환경설정 로드 잘 되나요? 좀 이상하지만 prefPane 빌드할 때는 코드 순서만 바꿔도 로딩이 안되는 경우가 종종 있었기 때문에 파일 나누는게 좀 걱정이 됩니다.

@@ -39,7 +39,7 @@ enum ChangeLayout {
case toggleByCapsLock
case hangul
case roman
case hanja
case hanjaEmoji

This comment has been minimized.

Copy link
@youknowone

youknowone Oct 5, 2019

Member

searching composer를 만들었으니 search로 바꾸면 어떨까요

@presto95

This comment has been minimized.

Copy link
Contributor Author

presto95 commented Oct 5, 2019

넵 환경설정 잘 뜨는 것 확인했습니다.

@youknowone youknowone merged commit ab4e3f0 into gureum:master Oct 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@youknowone

This comment has been minimized.

Copy link
Member

youknowone commented Oct 5, 2019

감사합니다!

@presto95 presto95 deleted the presto95:preferences branch Oct 6, 2019
@youknowone youknowone added this to the 컨트리뷰톤 2019 milestone Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.