Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration Window 기초 #679

Merged
merged 1 commit into from Nov 4, 2019

Conversation

@youknowone
Copy link
Member

youknowone commented Nov 3, 2019

창이 중복해서 뜨는 문제가 있지만 기본적인 동작은 합니다.

#604 를 올바르게 수정할 수 없어 메뉴의 환경설정을 되살림

@youknowone youknowone requested a review from yous Nov 3, 2019
Copy link
Member

yous left a comment

'설정하러 이동하기' 버튼이 동작 안 하는 것 같은데, 이건 따로 고치도록 하고 일단 좋아보입니다.

<scene sceneID="lqC-Y3-iGO">
<objects>
<windowController id="pWa-Qg-gE8" customClass="ConfiguraionWindowController" customModule="Gureum" customModuleProvider="target" sceneMemberID="viewController">
<window key="window" title="Window" allowsToolTipsWhenApplicationIsInactive="NO" autorecalculatesKeyViewLoop="NO" releasedWhenClosed="NO" visibleAtLaunch="NO" frameAutosaveName="" animationBehavior="default" id="66I-Xz-bUA">

This comment has been minimized.

Copy link
@yous

yous Nov 3, 2019

Member

여기 title 적당히 바꿔주면 좋을 것 같습니다.

@youknowone youknowone force-pushed the youknowone:configuration branch from d26e33a to a9af1d7 Nov 4, 2019
창이 중복해서 뜨는 문제가 있지만 기본적인 동작은 합니다
@youknowone youknowone force-pushed the youknowone:configuration branch from a9af1d7 to 7c524d5 Nov 4, 2019
@youknowone youknowone merged commit 030c224 into gureum:master Nov 4, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@youknowone

This comment has been minimized.

Copy link
Member Author

youknowone commented Nov 4, 2019

수정하고 머지했습니다

@youknowone youknowone deleted the youknowone:configuration branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.