Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up GuiComponents #31

Open
gurkenlabs opened this issue Oct 1, 2017 · 0 comments
Open

Clean up GuiComponents #31

gurkenlabs opened this issue Oct 1, 2017 · 0 comments

Comments

@ghost
Copy link
Collaborator

@ghost ghost commented Oct 1, 2017

Currently the implementation of our GuiComponents is not as clean as we want it to be.

  • Constructors with large amounts of parameters
  • Inconsistent behavior
  • Not 100% completed implementations

(There are a lot of codesmells related to these components)

We should streamline all our GUI components and clearly define what they can do and what they can't.
The most important topic is the ease of use of the component interfaces.

  • Introduce a Z-Order (distinguish mouse events -> only top most component)
  • Add documentation about GuiComponents.
  • Test remaining implementations
gurkenlabs pushed a commit that referenced this issue Apr 26, 2018
Rename setPosition to setLocation for consitency reasons.
The setPosition methods now reuse the setters for x and y internally.

Issue #31
@steffen-wilke steffen-wilke added the MAJOR label Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.