New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CombatAttributes #89

Closed
gurkenlabs opened this Issue Feb 24, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@ghost
Copy link
Collaborator

ghost commented Feb 24, 2018

Currently, the CombatAttributes class contains a lot of logic that are rather typical for games where entities have certain stats (e.g. rpg).
They were explicitly added for the little bit ambiguous approach of creating LITI.

The following attributes are very genre specific and should therefore be removed from the general engine implementation:

  • experience
  • level and level-up logic
  • attack speed
  • health regeneration
  • shield
  • vision

Also, all related AttributeEffects should be removed from the engine.

For LITI, we could move these implementations to maybe a litiengine-rpg assembly.

steffen-wilke added a commit that referenced this issue Sep 25, 2018

Remove further non-general combat attributes
- Remove shield
- Remove attack speed
- Remove health regeneration
- Remove vision

Issue #89

steffen-wilke added a commit that referenced this issue Sep 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment