Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor gameinfo #125

Merged
merged 3 commits into from May 8, 2018

Conversation

@ghost
Copy link
Collaborator

commented May 8, 2018

This change takes care of the inconsistencies of the GameInfo class.
It not only provided information about the game but also the defaultRenderScale and even some unused fields.

We've also extended the GameInfo with more detailed information about the game (e.g. publisher or website) and additionally provided the possibility to add custom properties for even more project specific information.

Gurkenlabs added 3 commits May 8, 2018
Gurkenlabs
Refactor the GameInfo
Remove logo String.
Remove icon String.
Move renderScale to the IRenderEngine implementation.
The GameInfo now only contains basic data about the game (name, description...) and no configuration parts of the engine anymore.
Update utiliti tray icon.
Gurkenlabs
Extend the GameInfo
- Added support for custom properties
- Added website
- Added possibility to get the website as URL

The toString() implementation has been moved to a custom getTitle() method because it essentially provided only the default value for the title of the game window.
It is now possible to set the info of a game by either a GameInfo object or a resource XML-file.
@steffen-wilke
Copy link
Collaborator

left a comment

Thats perfect 👍

@@ -49,18 +61,27 @@ public String getDescription() {
}

@XmlTransient
public String[] getDevelopers() {
return this.developers;
public String getWebsite() {

This comment has been minimized.

Copy link
@steffen-wilke

steffen-wilke May 8, 2018

Collaborator

Just a review test.

@steffen-wilke
Copy link
Collaborator

left a comment

Nothing else to do here!

@steffen-wilke steffen-wilke merged commit de30cf7 into master May 8, 2018

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@steffen-wilke steffen-wilke deleted the refactor-gameinfo branch May 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.