New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tile custom properties (cont.) #151

Merged
merged 12 commits into from Jul 25, 2018

Conversation

Projects
None yet
2 participants
@TheRamenChef
Copy link
Collaborator

TheRamenChef commented Jul 24, 2018

I missed something when I was implementing the tile custom properties: it doesn't work with external tilesets, because those are loaded after the custom property sources are assigned. Unfortunately, this slipped past the unit test.

This pull request also corrects an error in the test map regarding the first global ids.

TheRamenChef and others added some commits Jul 23, 2018

Merge pull request #7 from gurkenlabs/master
Fast forward to gurkenlabs revision
Don't use BufferedInputStream if marking is already supported
If the input stream already supports mark+reset (for example a
URLClassLoader uses ByteInputStream), then wrapping it in a buffer just
adds overhead.

@steffen-wilke steffen-wilke merged commit 171d756 into gurkenlabs:master Jul 25, 2018

2 checks passed

codeclimate 1 fixed issue
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment