Fix ArraIndexOutOfBoundsException #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the discord: These return statements erroneously subtract 1 when they shouldn't which can cause the index to underflow. Ex: If the name is 4 characters long then: ```java return name.substring(0, name.length() - state.spriteString().length() - 1); ``` is actually ```java return name.substring(0, 4 - 4 - 1) ``` `4 - 4 - 1 = -1` which is less than 0, and therefor invalid.
nightm4re94
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the discord:
https://discord.com/channels/326074836508213258/517120478557634580/814282223641296936
These return statements erroneously subtract 1 when they shouldn't which can cause the index to underflow.
Ex: If the name is 4 characters long then:
is actually
4 - 4 - 1 = -1which is less than 0, and therefor invalid.Test before merging.