Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6 new App icons #102

Closed
wants to merge 12 commits into from

Conversation

Projects
None yet
2 participants
@iLynux8888
Copy link

commented Mar 6, 2019

I have created some icons I think would benefit this theme. I am not very good at GitHub, so I don't know what else I need to do, but I have the SVG files ready for approval. I just don't know what to do with them.
The apps I created icons for are as follows:

  • Google Docs
  • Google Sheets
  • Google Slides
  • Hulu
  • Android Messages
  • Google Duo

Thank you for your help.

gusbemacbe added some commits Mar 5, 2019

@iLynux8888 iLynux8888 changed the title Beta 6 new App icons Mar 6, 2019

@gusbemacbe

This comment has been minimized.

Copy link
Owner

commented Mar 6, 2019

Hi @iLynux8888 !

You did something wrong. I will train now you. Please avoid uploading the files to the branches master and beta, because these branches are for you to upgrade my upstream Github repository. You need to create the new branch.

  1. Make backup of your files that you have created
  2. Remive your repository
  3. Fork my repository
  4. Open the terminal and run:
git clone https://github.com/iLynux8888/suru-plus
cd suru-plus
git checkout -b new_icons
git push origin new_icons
  1. Put your files you made backup and run:
git add .
git commit -m "Addeed new icons"
git push
# Type your username and your password
  1. Open the Github site and go to your repository.
  2. Click "Branch: master" and switch to "new_icons"
  3. Create a pull request and select "gusbemacbe:beta". Ready.
  4. Once I approve, you need to delete the branch

Tip

You do not need to remove and fork every time, you can delete only the branches you created.

When I upgrade something in my repository, you need to switch from the deleted branch to the branch master:

cd suru-plus
git fetch origin
git checkout master
git remote add upstream https://github.com/gusbemacbe/suru-plus
git pull upstream master 
git add .
git push
Samuel Asher
@iLynux8888

This comment has been minimized.

Copy link
Author

commented Mar 7, 2019

Thank you so much! I have done all of the above.

@gusbemacbe

This comment has been minimized.

Copy link
Owner

commented Mar 7, 2019

Ready! I merged.

@gusbemacbe gusbemacbe closed this Mar 7, 2019

@iLynux8888

This comment has been minimized.

Copy link
Author

commented Mar 7, 2019

Thanks! I am happy to have contributed. And thanks again for the help. I hope you like the new icons.

@gusbemacbe

This comment has been minimized.

Copy link
Owner

commented Mar 7, 2019

You are welcome. I like more the icons of Android Message, Hulu and the alternative icons of Nautilus and Terminal. They are very beautiful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.