Resolve issue #13 by making cluster_utils.get_cluster_info less brittle. #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you very much for help. I merged your changes with small style changes (regarding flake8). |
matteiuspi
pushed a commit
to CashStar/django-elasticache
that referenced
this pull request
Mar 19, 2021
Initial Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in response to Issue #13, which I submitted earlier today. I fixed the issue by increasing the number of space-delimited "parts" of the version string to be either two or three. This is about as narrow of a fix as I could come up with.
I have also written a test case to replicate the issue; it's included in the commit.