Add command to generate Bash autocomplete script #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| use Symfony\Component\Console\Input\InputInterface; | ||
| use Symfony\Component\Console\Input\InputOption; | ||
| use Symfony\Component\Console\Output\OutputInterface; | ||
| use Symfony\Component\Console\Helper\DescriptorHelper; |
There was a problem hiding this comment.
this should go below line 14 right?
|
|
||
| $scriptFile = $config->get('home').DIRECTORY_SEPARATOR.self::AUTOCOMPLETE_SCRIPT; | ||
|
|
||
| $file = @file_put_contents($scriptFile, $script); |
There was a problem hiding this comment.
Maybe use Symfony Filesystem::dump()?
|
The inspection completed: 23 new issues, 7 updated code elements |
|
|
||
| $dump = array_map(function ($options) use ($commonOptions) { | ||
| return array_diff($options, $commonOptions); | ||
| }, $dump); |
There was a problem hiding this comment.
can we break the line on 82 and have the closure starting on the L83 and then after the , we break again to line up $dump with the closure?
There was a problem hiding this comment.
that will line up L82 $dump = ... start with the closing ;
|
merging as @pierredup will send another PR covering the changes, thanks 👍 great job 😊 |
cordoval
added a commit
that referenced
this pull request
Jun 17, 2014
Add command to generate Bash autocomplete script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add command to generate script for Bash autocompletion. This script allows autocomplete support when typing "gush" followed by a [tab], which gives you all the available commands, as well as the options for the commands
Sent using Gush