{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":138756608,"defaultBranch":"master","name":"pytorch","ownerLogin":"gustavla","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2018-06-26T15:19:19.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/902935?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1714020585.0","currentOid":""},"activityList":{"items":[{"before":"0fa10313cfe6e52dff91c23277eeb6e569151fdc","after":"80daf4edbdea5d20a11f83b332caaf40a86b0813","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_G_6","pushedAt":"2024-05-15T23:31:46.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Cache SetGraphInputTypeReliable\n\n- For each node that is processed in onnx.export, a check is run to see\n  if all inputs are \"reliable\" (static shape, etc.). This value does not\n  change, so it is much faster to cache it on the first computation.\n  The caching is added to the ConstantMap state.\n- Resolves (6) in #121422.","shortMessageHtmlLink":"Cache SetGraphInputTypeReliable"}},{"before":"5f4e843c26b1d3337b1766415b51544513ffa716","after":"0fa10313cfe6e52dff91c23277eeb6e569151fdc","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_G_6","pushedAt":"2024-05-15T21:41:34.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"pytorchmergebot","name":null,"path":"/pytorchmergebot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/97764156?s=80&v=4"},"commit":{"message":"Char got lost in rebase","shortMessageHtmlLink":"Char got lost in rebase"}},{"before":"d19dd69c92617c4a3f4de816b82d317be01234c3","after":"0f522cec6ad8063325946aa12f4f158b1feca0a5","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_B_1","pushedAt":"2024-05-15T17:32:17.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Introduce explicit scope, and change comment","shortMessageHtmlLink":"Introduce explicit scope, and change comment"}},{"before":"02a99b48be7381121851f21fd2651e5515e40572","after":"5f4e843c26b1d3337b1766415b51544513ffa716","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_G_6","pushedAt":"2024-05-14T20:09:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Char got lost in rebase","shortMessageHtmlLink":"Char got lost in rebase"}},{"before":"7f8e68767e7ffeec90072915b0044a33b6b918a0","after":"9d90fb6c6749f9ab77c960d8863d1de8972a6637","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_H_7","pushedAt":"2024-05-14T20:07:41.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Add comment about dual DimSymbolMap/SymbolDimMap","shortMessageHtmlLink":"Add comment about dual DimSymbolMap/SymbolDimMap"}},{"before":"a8fc0a78017b56e42210c4b231f300d2b0c7aeed","after":"02a99b48be7381121851f21fd2651e5515e40572","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_G_6","pushedAt":"2024-05-14T18:48:02.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Add comment with motivation","shortMessageHtmlLink":"Add comment with motivation"}},{"before":"8d421d8801e8629d87566e044b6c88e1070ded29","after":"7f8e68767e7ffeec90072915b0044a33b6b918a0","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_H_7","pushedAt":"2024-05-14T18:38:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Add comment about dual DimSymbolMap/SymbolDimMap","shortMessageHtmlLink":"Add comment about dual DimSymbolMap/SymbolDimMap"}},{"before":"bcfc89a25a617103e78d9d73681d4fb71d7fa52b","after":"a8fc0a78017b56e42210c4b231f300d2b0c7aeed","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_G_6","pushedAt":"2024-05-14T16:46:46.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Add comment with motivation","shortMessageHtmlLink":"Add comment with motivation"}},{"before":"7b7e13440b6260b30facc3a869d5ad5f6af2572f","after":"d19dd69c92617c4a3f4de816b82d317be01234c3","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_B_1","pushedAt":"2024-05-14T16:11:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Introduce explicit scope, and change comment","shortMessageHtmlLink":"Introduce explicit scope, and change comment"}},{"before":"bc0a4fe8c628fef09377f1cea93220319670def1","after":"6c2b2fa962a82ffeb6fec0ab66e8fe29e712cad2","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_E_8","pushedAt":"2024-05-14T15:03:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Tweak comment text some more","shortMessageHtmlLink":"Tweak comment text some more"}},{"before":"c61b6033956b448b380ad2f242da5d5d92a8519c","after":"8d421d8801e8629d87566e044b6c88e1070ded29","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_H_7","pushedAt":"2024-05-14T14:52:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Add comment about dual DimSymbolMap/SymbolDimMap","shortMessageHtmlLink":"Add comment about dual DimSymbolMap/SymbolDimMap"}},{"before":"c451302da5d119214f68661b59b6754fa170343f","after":"bc0a4fe8c628fef09377f1cea93220319670def1","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_E_8","pushedAt":"2024-05-10T15:59:29.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Add motivating comment AllGraphInputsStaticWithCaching","shortMessageHtmlLink":"Add motivating comment AllGraphInputsStaticWithCaching"}},{"before":"935fc7dc945ed3e375010c48ef5b9a6d10b1359a","after":"c61b6033956b448b380ad2f242da5d5d92a8519c","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_H_7","pushedAt":"2024-05-09T19:33:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Add comment about dual DimSymbolMap/SymbolDimMap","shortMessageHtmlLink":"Add comment about dual DimSymbolMap/SymbolDimMap"}},{"before":"908a102c5ed6b8d8b3e1d7d51d3958b8de586851","after":"c451302da5d119214f68661b59b6754fa170343f","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_E_8","pushedAt":"2024-05-09T18:35:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Add motivating comment AllGraphInputsStaticWithCaching","shortMessageHtmlLink":"Add motivating comment AllGraphInputsStaticWithCaching"}},{"before":"b59ab82d213ae68077f414e085b674fc264ecc7d","after":"07262461455192828170cedabec4a7fe285c1287","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_D_4_real","pushedAt":"2024-05-09T18:28:25.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Avoid linear look up in env for exist_in_env\n\n- As part of torch.onnx.export, a reverse look-up is made in env. This\n  is done for each node, and this look-up costs in proportion to the\n  graph size, which incurs and overall O(N^2) time complexity.\n- A pragmatic solution is simply to keep a separate data structure to\n  make this de facto constant time. So, this introduces a set containing\n  all the values of env.\n- Resolves (4) in #121422.","shortMessageHtmlLink":"Avoid linear look up in env for exist_in_env"}},{"before":"22df3e05e94c9eb42b94bbe3321f37ba76dc2bb7","after":"461ca3f21fc1289807ee47dc23f3245d9a6dced1","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_B_1_real","pushedAt":"2024-05-09T04:26:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"pytorchmergebot","name":null,"path":"/pytorchmergebot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/97764156?s=80&v=4"},"commit":{"message":"Compare as python object","shortMessageHtmlLink":"Compare as python object"}},{"before":"ab070ac45e1da9dfca7abaa1c8a9b48677cc7533","after":"b59ab82d213ae68077f414e085b674fc264ecc7d","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_D_4_real","pushedAt":"2024-04-25T15:57:11.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Avoid linear look up in env for exist_in_env\n\n- As part of torch.onnx.export, a reverse look-up is made in env. This\n  is done for each node, and this look-up costs in proportional to the\n  graph size, which incurs and overall O(N^2) time complexity.\n- A pragmatic solution is simply to keep a separate data structure to\n  make this de facto constant time. So, this introduces a set containing\n  all the values of env.\n- Resolves (4) in #121422.\n- This code change and the choice of py::set looks a bit more natural on\n  top of #123063, where the env is changed from a std::unordered_map to\n  a py::dict.","shortMessageHtmlLink":"Avoid linear look up in env for exist_in_env"}},{"before":null,"after":"bcfc89a25a617103e78d9d73681d4fb71d7fa52b","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_G_6","pushedAt":"2024-04-25T04:49:45.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Cache SetGraphInputTypeReliable\n\n- For each node that is processed in onnx.export, a check is run to see\n  if all inputs are \"reliable\" (static shape, etc.). This value does not\n  change, so it is much faster to cache it on the first computation.\n  The caching is added to the ConstantMap state.\n- Resolves (6) in #121422.","shortMessageHtmlLink":"Cache SetGraphInputTypeReliable"}},{"before":null,"after":"54f168a650df16a5d52c33b5e92962b08537898e","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_F_5","pushedAt":"2024-04-25T04:40:04.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Cache AllGraphInputsStatic instead of re-computing\n\n- The inputs (dynamic inputs and constants) do not change as nodes\n  are processed one by one and is expensive to re-compute for every node.\n- Instead, introduce AllGraphInputsStaticWithCaching that sets a state\n  in ConstantMap and refers to in subsequent nodes.\n- Move AllGraphInputsStatic out of anonymous namespace and add to\n  header, so that it can be important and used in onnx.cpp.\n- Resolves (5) in #121422.","shortMessageHtmlLink":"Cache AllGraphInputsStatic instead of re-computing"}},{"before":null,"after":"5956ebf5766c48d60cc6bb9e27bf012649126148","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_I_9","pushedAt":"2024-04-25T04:27:07.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Introduce reverse of symbol_dim_map.\n\n- Add a reverse look-up `dim_symbol_map` that is kept in parallel of\n  `symbol_dim_map`. This avoids a linear time look-up, which creates a\n  quadratic export time complexity.\n- Resolves (9) in #121422.","shortMessageHtmlLink":"Introduce reverse of symbol_dim_map."}},{"before":"6e80e7f0f3d01a7aed6bcfad7e862e143c009f45","after":"ab070ac45e1da9dfca7abaa1c8a9b48677cc7533","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_D_4_real","pushedAt":"2024-04-25T04:20:19.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Avoid linear look up in env for exist_in_env\n\n- As part of torch.onnx.export, a reverse look-up is made in env. This\n  is done for each node, and this look-up costs in proportional to the\n  graph size, which incurs and overall O(N^2) time complexity.\n- A pragmatic solution is simply to keep a separate data structure to\n  make this de facto constant time. So, this introduces a set containing\n  all the values of env.\n- Resolves (4) in #121422.\n- This code change and the choice of py::set looks a bit more natural on\n  top of #123063, where the env is changed from a std::unordered_map to\n  a py::dict.","shortMessageHtmlLink":"Avoid linear look up in env for exist_in_env"}},{"before":"6a1a850b60750cbcbdf9dc0ea1b6bb40b3b4b81a","after":"6e80e7f0f3d01a7aed6bcfad7e862e143c009f45","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_D_4_real","pushedAt":"2024-04-25T04:18:51.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Avoid linear look up in env for exist_in_env\n\n- As part of torch.onnx.export, a reverse look-up is made in env. This\n  is done for each node, and this look-up costs in proportional to the\n  graph size, which incurs and overall O(N^2) time complexity.\n- A pragmatic solution is simply to keep a separate data structure to\n  make this de facto constant time. So, this introduces a set containing\n  all the values of env.\n- Resolves (4) in #121422.\n- This code change and the choice of py::set looks a bit more natural on\n  top of #123063, where the env is changed from a std::unordered_map to\n  a py::dict.","shortMessageHtmlLink":"Avoid linear look up in env for exist_in_env"}},{"before":"7715f1bd39c7e760f18208c70d776153ba99d34f","after":"6a1a850b60750cbcbdf9dc0ea1b6bb40b3b4b81a","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_D_4_real","pushedAt":"2024-04-25T04:13:42.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Avoid linear look up in env for exist_in_env\n\n- As part of torch.onnx.export, a reverse look-up is made in env. This\n  is done for each node, and this look-up costs in proportional to the\n  graph size, which incurs and overall O(N^2) time complexity.\n- A pragmatic solution is simply to keep a separate data structure to\n  make this de facto constant time. So, this introduces a set containing\n  all the values of env.\n- Resolves (4) in #121422.\n- This code change and the choice of py::set looks a bit more natural on\n  top of #123063, where the env is changed from a std::unordered_map to\n  a py::dict.","shortMessageHtmlLink":"Avoid linear look up in env for exist_in_env"}},{"before":null,"after":"7715f1bd39c7e760f18208c70d776153ba99d34f","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_D_4_real","pushedAt":"2024-04-25T04:07:54.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Avoid linear look up in env for exist_in_env\n\n- As part of torch.onnx.export, a reverse look-up is made in env. This\n  is done for each node, and this look-up costs in proportional to the\n  graph size, which incurs and overall O(N^2) time complexity.\n- A pragmatic solution is simply to keep a separate data structure to\n  make this de facto constant time. So, this introduces a set containing\n  all the values of env.\n- Resolves (4) in #121422.\n- This code change and the choice of py::set looks a bit more natural on\n  top of #123063, where the env is changed from a std::unordered_map to\n  a py::dict.","shortMessageHtmlLink":"Avoid linear look up in env for exist_in_env"}},{"before":"7ae92af7cec40f9d7d3499c4fc06c31725a1ed4d","after":"74ea2f9cb44ce6e6780a706b5c208625fff40598","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_D_4","pushedAt":"2024-04-19T03:28:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Add default value and docstring to new_nodes","shortMessageHtmlLink":"Add default value and docstring to new_nodes"}},{"before":null,"after":"1f1dbab6a711751192e1661ce765c1a29f5a0105","ref":"refs/heads/dev/gustlars/main_apr17_plus_fast_onnx_export","pushedAt":"2024-04-18T02:57:04.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Add default value and docstring to new_nodes","shortMessageHtmlLink":"Add default value and docstring to new_nodes"}},{"before":"8297f6766d4cbcee9319bd56279de08199300a8f","after":"7ae92af7cec40f9d7d3499c4fc06c31725a1ed4d","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_D_4","pushedAt":"2024-04-10T16:05:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Add default value and docstring to new_nodes","shortMessageHtmlLink":"Add default value and docstring to new_nodes"}},{"before":"3b24c8106b22499d64d2c80329d9a0399f323831","after":"8297f6766d4cbcee9319bd56279de08199300a8f","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_D_4","pushedAt":"2024-04-10T03:27:33.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Add default value and docstring to new_nodes","shortMessageHtmlLink":"Add default value and docstring to new_nodes"}},{"before":"a5921d80cc64c3c30b19f831e72d6170b3c21af4","after":"3b24c8106b22499d64d2c80329d9a0399f323831","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_D_4","pushedAt":"2024-04-10T03:26:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Add default value and docstring to new_nodes","shortMessageHtmlLink":"Add default value and docstring to new_nodes"}},{"before":"e785855ead8dc9f41ea505addbcb19b981de4ded","after":"22df3e05e94c9eb42b94bbe3321f37ba76dc2bb7","ref":"refs/heads/dev/gustav/onnx_export_speedup_121422_B_1_real","pushedAt":"2024-04-09T01:19:03.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gustavla","name":"Gustav Larsson","path":"/gustavla","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/902935?s=80&v=4"},"commit":{"message":"Compare as python object","shortMessageHtmlLink":"Compare as python object"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAESw8HgAA","startCursor":null,"endCursor":null}},"title":"Activity · gustavla/pytorch"}