Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(unit): unit tests with Jest #8

Merged
merged 1 commit into from Jan 22, 2019
Merged

test(unit): unit tests with Jest #8

merged 1 commit into from Jan 22, 2019

Conversation

barsheshet
Copy link
Contributor

  • Introducing Jest
  • index unit tests
  • namespace unit tests
  • upgrade "request" to fix known vulnerabilities

@barsheshet
Copy link
Contributor Author

@guyguyon BTW,

This is me ,Guy, from "Shevet Rehasim" if you remember...
You have no public email so i couldn't reach you.

guyguyon
guyguyon reviewed Jan 22, 2019
View reviewed changes
spec/index.spec.js
it('should get the created namespace', () => {
asyncHooks.createHook.mockReturnValueOnce({ enable: () => true });
const yam = createNamespace('yam');
const yabasha = getNamespace('yam');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahaha

@guyguyon
Copy link
Owner

@barsheshet What's up! long time....
Your PR is great. Thanks.
If you want, you can add some e2e tests.
Something with a real async operation.
Let me know if you want, otherwise, i'll merge it

@barsheshet
Copy link
Contributor Author

Sure. I'll add integration/e2e tests in a different PR when i find the time.
Meanwhile you can go ahead and merge it.

@guyguyon guyguyon merged commit 8919e03 into guyguyon:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guyguyon guyguyon guyguyon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@barsheshet @guyguyon