Fixed broken links when % is in the title of an article #1

Open
wants to merge 1 commit into
from

2 participants

@hughht5

used encodeURI() on the link for the article title

@hughht5 hughht5 Fixed broken links when % is in the title
used encodeURI() on the link for the article title
710df94
@guyht
Owner

Hi Hugh,

Could you fix this in Glog rather than in Guido. The article.url should be encoded before it is sent to the template player. You might also want to add a test case ;)

G

I can have a look again. I've fixed it for mine in the template for now - I'll fix it properly later. I haven't used jade before so I'm trying to work out how it's called.

H

Owner

Hugh, there is a curly bracket missing on line 20, could you add it and I will merge this.

Thanks

... I'll have to have another look at it. I'm still getting broken links so I'll send another pull request when complete.

Basically this fix will work on clicking titles on the main page, but not from the rss feed. I'll fix the glog code and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment