New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix count being called on null #1686

Merged
merged 1 commit into from Dec 15, 2016

Conversation

Projects
None yet
4 participants
@kelunik
Contributor

kelunik commented Dec 15, 2016

PHP 7.2 requires arguments to count being an array or an instance of Countable.

This property when not initialized, is neither of these, it's null.

Fix count being called on null
PHP 7.2 requires arguments to count being an array or an instance of Countable.

This property when not initialized, is neither of these, it's null.
@sagikazarmark

This comment has been minimized.

Contributor

sagikazarmark commented Dec 15, 2016

Thanks

@sagikazarmark sagikazarmark merged commit dfadff3 into guzzle:master Dec 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kelunik kelunik deleted the kelunik:count branch Dec 15, 2016

rxu added a commit to rxu/phpbb3 that referenced this pull request Mar 20, 2017

rxu added a commit to rxu/phpbb3 that referenced this pull request Mar 20, 2017

rxu added a commit to rxu/phpbb3 that referenced this pull request Mar 21, 2017

rxu added a commit to rxu/phpbb3 that referenced this pull request May 6, 2017

rxu added a commit to rxu/phpbb3 that referenced this pull request May 9, 2017

@rxu

This comment has been minimized.

rxu commented on 375c01b May 12, 2017

Any chance this commit will be ever included into release?

This comment has been minimized.

patrickallaert replied Jun 1, 2017

+1 for @rxu 's question

jakubkulhan added a commit to jakubkulhan/chrome-devtools-protocol that referenced this pull request Dec 11, 2017

pfrenssen added a commit to drupaltest/behat-traits that referenced this pull request Oct 17, 2018

Fix test failure on PHP 7.2 caused by Guzzle.
We do not directly depend on Guzzle, but our tests are failing on PHP
7.2 due to a property not being correctly initialized.

Ref. guzzle/guzzle#1686
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment