fixed php 7.2 Warning: count(): Parameter must be an array or an obj…#2038
Closed
firma wants to merge 1 commit into
Closed
fixed php 7.2 Warning: count(): Parameter must be an array or an obj…#2038firma wants to merge 1 commit into
firma wants to merge 1 commit into
Conversation
…ct that implements Countable fixed php 7.2 ,Warning: count(): Parameter must be an array or an object that implements Countable
Author
|
fixed php 7.2 Warning: count(): Parameter must be an array or an object that implements Countable |
Member
|
👎 Why is this ever null. Instead, the place that incorrectly sets it to null should be fixed. |
|
it has fix? |
marekr
reviewed
Apr 22, 2018
Nyholm
requested changes
Apr 23, 2018
Nyholm
left a comment
Member
There was a problem hiding this comment.
I agree with @GrahamCampbell. Why is $this->handles null? We should fix that.
Member
|
After a quick look: I don't see any code paths that would end up in |
|
I have the same error in my codebase....I'll take a look at what exactly is failing. |
|
This has been fixed in #1686. This can be closed. |
PierreMaurel
reviewed
Nov 1, 2018
| unset($easy->handle); | ||
|
|
||
| if (count($this->handles) >= $this->maxHandles) { | ||
| if (is_array($this-handles) && count($this->handles) >= $this->maxHandles) { |
There was a problem hiding this comment.
the count function does support null in php 7.2 .
Merged
renishkhunt
approved these changes
Jul 2, 2019
GrahamCampbell
requested changes
Jul 2, 2019
GrahamCampbell
left a comment
Member
There was a problem hiding this comment.
This PR is no longer required, and can be closed.
Member
|
Ping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ect that implements Countable
fixed php 7.2 ,Warning: count(): Parameter must be an array or an object that implements Countable