6.x will only get security fixes #2787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmponos
approved these changes
Sep 30, 2020
|
🙏 |
|
Thanky ou |
|
Wonder if that table should have a maximum PHP version in the bounds too. Only Guzzle 7 will run on PHP 8. |
|
I just checked. Guzzle 3, 4, 5 and 6 has no upper bound to the PHP version in composer.json. That was introduced in Guzzle 7.0 So if you ask packagist, then Guzzle 7 is the only one that CANNOT run on PHP 8. For that reason, I dont think we should add maximum PHP version in this table. Let's focus on PHP 8 support for Guzzle 7 instead. |
|
Just because there is no upper bound, doesn't mean that we actually support those higher PHP versions. We should indicate to users what we know works, but not pretend Guzzle 4 works on PHP 8 when it doesn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.