Remove curl auth on cross-domain redirects

[kkopachev]

Fixes #1477

[TimWolla]

As a non-maintainer that eyeballed the diff this LGTM.

[GrahamCampbell]

Do we actually want to support someone circumventing Guzzle's abstraction, and setting auth headers directly through curl options?

[TimWolla]

@GrahamCampbell My understanding is that this is related to this:

guzzle/src/Client.php

Lines 405 to 413 in 3a0543e

	case 'digest':
	// @todo: Do not rely on curl
	$options['curl'][\CURLOPT_HTTPAUTH] = \CURLAUTH_DIGEST;
	$options['curl'][\CURLOPT_USERPWD] = "$value[0]:$value[1]";
	break;
	case 'ntlm':
	$options['curl'][\CURLOPT_HTTPAUTH] = \CURLAUTH_NTLM;
	$options['curl'][\CURLOPT_USERPWD] = "$value[0]:$value[1]";
	break;

[GrahamCampbell]

Ah, I see that "todo" is what needs resolving.

[kkopachev]

I looked at the todo item before submitting this PR and resolved to submitting PR anyway. I have 2 reasons for that:

• This PR fixes issue. Probably not the ideal way for ideal world, but it fixes it now.
• It is 6 years since this todo was first created. Digest auth provide no advantages over https+basic auth and therefore not so much popular and usage would probably decline over time. NTLM auth is explicitly disabled at stream handler because such auth requires keep-alive connection and stream handler closes stream after each request.

tl;dr: a fix is better than no fix for issue being open for so long with low chances of proper fix.

[kkopachev]

Is there anything else I could do for this PR?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 2 weeks if no further activity occurs. Thank you for your contributions.

[kkopachev]

ping? Somebody wants to re-run all checks and merge it in?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 2 weeks if no further activity occurs. Thank you for your contributions.

[kkopachev]

Rebased on latest master. Please take a look.

[Nyholm]

Thank you